Fixed bug when calling cursor.parse() multiple times with the same SQL.

Author: anthony-tuininga

doc/src/release_notes.rst

@@ -25,6 +25,7 @@ Thin Mode Changes
     in socket reads.
 #)  Eliminated unnecessary restriction that resulted in error
     ``DPY-3011: server logon version is not supported``.
+#)  Fixed bug when calling cursor.parse() multiple times with the same SQL.
 
 Thick Mode Changes
 ++++++++++++++++++

src/oracledb/impl/thin/messages.pyx

@@ -486,7 +486,7 @@ cdef class MessageWithData(Message):
         if self.out_var_impls is None:
             return 0
         for var_impl in self.out_var_impls:
-            if var_impl.outconverter is None:
+            if var_impl is None or var_impl.outconverter is None:
                 continue
             var_impl._last_raw_value = \
                     var_impl._values[self.cursor_impl._last_row_index]
@@ -1904,7 +1904,7 @@ cdef class ExecuteMessage(MessageWithData):
         cdef:
             Statement stmt = self.cursor_impl._statement
         if stmt._cursor_id != 0 and not stmt._requires_full_execute \
-                and not stmt._is_ddl:
+                and not self.parse_only and not stmt._is_ddl:
             if stmt._is_query and not stmt._requires_define \
                     and self.cursor_impl.prefetchrows > 0:
                 self.function_code = TNS_FUNC_REEXECUTE_AND_FETCH

tests/test_4300_cursor_other.py

@@ -802,5 +802,18 @@ def test_4362_change_of_bind_type_with_define(self):
             self.cursor.execute(sql, int_col=1)
             self.assertEqual(self.cursor.fetchone(), row_for_1)
 
+    def test_4363_multiple_parse(self):
+        "4363 - test calling cursor.parse() twice with the same statement"
+        self.cursor.execute("truncate table TestTempTable")
+        data = (4363, "Value for test 4363")
+        self.cursor.execute("""
+                insert into TestTempTable (IntCol, StringCol1)
+                values (:1, :2)""", data)
+        sql = "update TestTempTable set StringCol1 = :v where IntCol = :i"
+        for i in range(2):
+            self.cursor.parse(sql)
+            self.cursor.execute(sql, ("Updated value", data[0]))
+
+
 if __name__ == "__main__":
     test_env.run_test_cases()