OpenGrok help uses bashism

kahatlen · kahatlen · commit 3479bf57a71e · 2018-04-13T12:35:09.000+02:00
On systems where /bin/sh is dash (like Debian), invoking OpenGrok help
will print the following error message along with its output:

./OpenGrok: 930: [: unexpected operator

Also, the --detailed option won't print all the detailed help.

This patch replaces a bashism (the == operator) with standard shell
syntax (the = operator).
diff --git a/OpenGrok b/OpenGrok
@@ -927,7 +927,7 @@ UpdateDescriptionCache()
 
 OpenGrokUsage()
 {
-    [ "$1" == "--detailed" ] && helpargs=$1
+    [ "$1" = "--detailed" ] && helpargs=$1
     echo "Options for opengrok.jar:" 1>&2
     ${DO} ${JAVA} ${JAVA_OPTS} -jar "${OPENGROK_JAR}" '-?' $helpargs
 }

Original file line number	Diff line number	Diff line change
`@@ -927,7 +927,7 @@ UpdateDescriptionCache()`
`927`	`927`
`928`	`928`	`OpenGrokUsage()`
`929`	`929`	`{`
`930`		`- [ "$1" == "--detailed" ] && helpargs=$1`
	`930`	`+ [ "$1" = "--detailed" ] && helpargs=$1`
`931`	`931`	`echo "Options for opengrok.jar:" 1>&2`
`932`	`932`	`${DO} ${JAVA} ${JAVA_OPTS} -jar "${OPENGROK_JAR}" '-?' $helpargs`
`933`	`933`	`}`