Push test and documentation updates

Author: sharadraju

doc/src/user_guide/troubleshooting.rst

@@ -96,7 +96,7 @@ DPI-1047
 
         - On Windows:
 
-          - If node-oracledb is using libraries from a local database installation, ensure that this database is the `currently configured database <https://www.oracle.com/pls/topic/lookup?ctx=dblatest&id=GUID-33D575DD-47FF-42B1-A82F-049D3F2A8791>`__.
+          - If node-oracledb is using libraries from a local database installation, ensure that this database is the `currently configured database <https://docs.oracle.com/pls/topic/lookup?ctx=db21&id=RIWIN-GUID-33D575DD-47FF-42B1-A82F-049D3F2A8791>`__.
 
           - If you are not using passing a library directory parameter to :meth:`oracledb.initOracleClient()`, then restart your command prompt and use ``set PATH`` to check if the environment variable has the correct Oracle Client listed before any other Oracle directories.
 

test/dbconfig.js

@@ -77,19 +77,16 @@ if (process.env.NODE_ORACLEDB_DRCP) {
   config.test.drcp = (process.env.NODE_ORACLEDB_DRCP.toLowerCase() === 'true');
 }
 
-if (!config.test.externalAuth) {
-  if (process.env.NODE_ORACLEDB_USER) {
-    config.user = process.env.NODE_ORACLEDB_USER;
-  } else {
-    throw new Error("Schema User name is not set! Set the Environment Variable NODE_ORACLEDB_USER.");
-  }
-
-  if (process.env.NODE_ORACLEDB_PASSWORD) {
-    config.password = process.env.NODE_ORACLEDB_PASSWORD;
-  } else {
-    throw new Error("Schema User Password is not set! Set the Environment Variable NODE_ORACLEDB_PASSWORD.");
-  }
+if (process.env.NODE_ORACLEDB_USER) {
+  config.user = process.env.NODE_ORACLEDB_USER;
+} else {
+  throw new Error("Schema User name is not set! Set the Environment Variable NODE_ORACLEDB_USER.");
+}
 
+if (process.env.NODE_ORACLEDB_PASSWORD) {
+  config.password = process.env.NODE_ORACLEDB_PASSWORD;
+} else {
+  throw new Error("Schema User Password is not set! Set the Environment Variable NODE_ORACLEDB_PASSWORD.");
 }
 
 if (process.env.NODE_ORACLEDB_QA) {

test/externalAuth.js

@@ -80,7 +80,7 @@ const dbConfig = require('./dbconfig.js');
 
     }); // 5.1.2
 
-    it("5.1.3 throws error when gettting connection from oracledb given only invalid 'user' when externalAuth is enabled", async function() {
+    it("5.1.3 throws error when getting connection from oracledb given only invalid 'user' when externalAuth is enabled", async function() {
 
       await assert.rejects(
         async () => {
@@ -97,7 +97,7 @@ const dbConfig = require('./dbconfig.js');
       );
     }); // 5.1.3
 
-    it("5.1.4 throws error when gettting connection from oracledb given only 'password' when externalAuth is enabled", async function() {
+    it("5.1.4 throws error when getting connection from oracledb given only 'password' when externalAuth is enabled", async function() {
 
       await assert.rejects(
         async () => {
@@ -251,7 +251,8 @@ const dbConfig = require('./dbconfig.js');
       // Main function of this case
       const connArr = []; // Initialize array of connections with IDs from 1 to 9
       for (let id = 1; id <= 9; id++) {
-        connArr[id] = await getConns(id);
+        // connArr index 0 stores ID=1, index 1 stores ID=2 ,...
+        connArr.push(await getConns(id));
       }
 
       await closeConns(connArr);
@@ -286,7 +287,8 @@ const dbConfig = require('./dbconfig.js');
       // Main function of this case
       const poolArr = []; // Initialize array of pools with IDs from 1 to 9
       for (let id = 1; id <= 9; id++) {
-        poolArr[id] = await getPools(id);
+        // poolArr index 0 stores ID=1, index 1 stores ID=2 ,...
+        poolArr.push(await getPools(id));
       }
 
       await closePools(poolArr);

test/jsonBind1.js

@@ -65,6 +65,7 @@ describe('253. jsonBind1.js', function() {
                      "    p_inout := p_inout; \n" +
                      "END;";
   let skip = false;
+  const defaultFetchTypeHandler = oracledb.fetchTypeHandler;
   before (async function() {
     oracledb.outFormat = oracledb.OUT_FORMAT_OBJECT;
     oracledb.extendedMetaData = true;
@@ -73,6 +74,15 @@ describe('253. jsonBind1.js', function() {
       skip = true;
       this.skip();
     }
+    oracledb.fetchTypeHandler = function(metaData) {
+      // overwrite default converter for CLOB, BLOB and VARCHAR type.
+      if (metaData.isJson && metaData.dbType !== oracledb.DB_TYPE_JSON) {
+        const myConverter = (v) => {
+          return v;
+        };
+        return {converter: myConverter};
+      }
+    };
     await conn.execute(create_table_sql);
     await conn.commit();
   });
@@ -85,6 +95,7 @@ describe('253. jsonBind1.js', function() {
     if (conn) {
       await conn.close();
     }
+    oracledb.fetchTypeHandler = defaultFetchTypeHandler;
   });
 
   beforeEach(async function() {

test/list.txt

@@ -181,8 +181,8 @@ Overview of node-oracledb functional tests
     5.1 tests that work both when DB has configured externalAuth and not configured
         5.1.1 can get connection from oracledb with correct user/password when externalAuth is disabled
         5.1.2 throws error when getting connection from oracledb with correct user/password when externalAuth is enabled
-        5.1.3 throws error when gettting connection from oracledb given only invalid 'user' when externalAuth is enabled
-        5.1.4 throws error when gettting connection from oracledb given only 'password' when externalAuth is enabled
+        5.1.3 throws error when getting connection from oracledb given only invalid 'user' when externalAuth is enabled
+        5.1.4 throws error when getting connection from oracledb given only 'password' when externalAuth is enabled
         5.1.5 can get pool from oracledb with user/password when externalAuth is disabled
         5.1.6 throws error when getting pool from oracledb given user/password when externalAuth is enabled
         5.1.7 throws error when getting pool from oracledb only given username when externalAuth is enabled