Fix tpcRecover to work with Thick mode

Author: sharadraju

doc/src/release_notes.rst

@@ -29,6 +29,11 @@ Thin Mode Changes
     provided for `Issue #1565 <https://github.com/oracle/node-oracledb/issues/
     1565>`__.
 
+Thick Mode Changes
++++++++++++++++++++
+
+#)  Fixed bug that causes Two-Phase Commit `tpcRecover` execution to fail.
+
 node-oracledb `v6.5.1 <https://github.com/oracle/node-oracledb/compare/v6.5.0...v6.5.1>`__ (23 May 2024)
 ---------------------------------------------------------------------------------------------------------
 

lib/connection.js

@@ -1570,6 +1570,8 @@ class Connection extends EventEmitter {
 // NOTE: breakExecution() should not be serialized
 Connection.prototype.break =
     nodbUtil.callbackify(Connection.prototype.breakExecution);
+Connection.prototype.tpcRecover =
+    nodbUtil.callbackify(Connection.prototype.tpcRecover);
 nodbUtil.wrapFns(Connection.prototype,
   "changePassword",
   "close",
@@ -1590,7 +1592,6 @@ nodbUtil.wrapFns(Connection.prototype,
   "tpcEnd",
   "tpcForget",
   "tpcPrepare",
-  "tpcRecover",
   "tpcRollback",
   "unsubscribe");
 

test/tpc.js

@@ -67,6 +67,7 @@ describe('259. tpc.js', function() {
 
   describe('259.2 TPC Functions', function() {
     let conn = null;
+    let dbaConn = null;
     const sql = `BEGIN
         DECLARE
             e_table_missing EXCEPTION;
@@ -84,13 +85,24 @@ describe('259. tpc.js', function() {
         return this.skip();
       conn = await oracledb.getConnection(dbConfig);
       await conn.execute(sql);
+
+      const dbaCredential = {
+        user: dbConfig.test.DBA_user,
+        password: dbConfig.test.DBA_password,
+        connectString: dbConfig.connectString,
+        privilege: oracledb.SYSDBA,
+      };
+      dbaConn = await oracledb.getConnection(dbaCredential);
     });
 
     after(async function() {
       if (conn) {
         conn.execute(`DROP TABLE TBL_259_2 PURGE`);
         await conn.close();
       }
+      if (dbaConn) {
+        await dbaConn.close();
+      }
     });
 
     it('259.2.1 test tpcBegin, tpcPrepare, tpcRollback', async function() {
@@ -265,6 +277,25 @@ describe('259. tpc.js', function() {
       );
       await conn.tpcRollback(xid);
     });
+
+    it('259.2.10 tpcRecover', async function() {
+      if (!dbConfig.test.DBA_PRIVILEGE)
+        this.skip();
+
+      const xid = {
+        formatId: 5000,
+        globalTransactionId: "txn5000",
+        branchQualifier: "branchId"
+      };
+
+      await conn.tpcBegin(xid, oracledb.TPC_BEGIN_NEW, 60);
+      await conn.tpcPrepare(xid);
+      const promise =  dbaConn.tpcRecover();
+      const res = await Promise.resolve(promise);
+      assert.strictEqual(res[0].formatId, 5000);
+      assert.strictEqual(res[0].globalTransactionId, "txn5000");
+      assert.strictEqual(res[0].branchQualifier, "branchId");
+    });
   });
 
   describe('259.3 TPC Functions with no default values', function() {