Fixed an issue with privileges that prevented the startup() function from bringing the database up

Author: sharadraju

doc/src/release_notes.rst

@@ -75,6 +75,9 @@ Thin Mode Changes
 Thick Mode Changes
 +++++++++++++++++++
 
+#)  Fixed an issue with privileges that prevented the startup() function from
+    bringing up the database.
+
 #)  Tightened code to avoid possible unexpected runtime errors during token
     callback.
 

lib/oracledb.js

@@ -124,14 +124,23 @@ function _initializeThinDriver() {
 // Returns a boolean indicating if the supplied value is a valid privilege.
 //---------------------------------------------------------------------------
 function _isPrivilege(value) {
+  // Privileges are mutually exclusive and cannot be specified together
+  // except SYSPRELIM, which cannot be specified alone, it is specified in a
+  // combo with SYSOPER or SYSDBA.  SYSPRELIM is used only for
+  // startup/shutdown
+
+  // If SYSPRELIM specified, clear the bit
+  if (value & constants.SYSPRELIM) {
+    value = value ^ constants.SYSPRELIM;
+  }
+
   return (
     value === constants.SYSASM ||
     value === constants.SYSBACKUP ||
     value === constants.SYSDBA ||
     value === constants.SYSDG ||
     value === constants.SYSKM ||
     value === constants.SYSOPER ||
-    value === constants.SYSPRELIM ||
     value === constants.SYSRAC
   );
 }

test/connection.js

@@ -362,6 +362,16 @@ describe('1. connection.js', function() {
       await pool.close(0);
     });
 
+    it('1.7.6 negative test case SYSPRELIM & SYSASM', async function() {
+      const credential = {...dbConfig,
+        privilege: oracledb.SYSASM | oracledb.SYSPRELIM
+      };
+      await assert.rejects(
+        async () => await oracledb.getConnection(credential),
+        /ORA-01031:/
+      );
+    });
+
   }); // 1.7
 
   describe('1.8 Ping method', function() {

test/list.txt

@@ -24,6 +24,7 @@ Overview of node-oracledb functional tests
         1.7.3 Negative value - random constants
         1.7.4 Negative value - NaN
         1.7.5 gets ignored when acquiring a connection from Pool
+        1.7.6 negative test case SYSPRELIM & SYSASM
     1.8 Ping method
         1.8.1 ping() checks the connection is usable
         1.8.2 closed connection