Add updates to documentation and more tests

Author: sharadraju

doc/src/user_guide/globalization.rst

@@ -51,7 +51,7 @@ To find the database's national character set, execute the query:
 Setting the Client Character Set
 --------------------------------
 
-In node-oracledb, the encoding used for all character data is "UTF-8".
+In node-oracledb, the encoding used for all character data is AL32UTF8.
 
 Setting the Client Locale
 =========================

doc/src/user_guide/introduction.rst

@@ -24,7 +24,7 @@ database options or packs.
 Node-oracledb is typically installed from the `npm registry <https://www.npmjs
 .com/package/oracledb>`__. See :ref:`installation` for more information.
 
-This node-oracledb release has been tested with Node.js 14, 16 and 18 on
+This node-oracledb release has been tested with Node.js 14, 16, 18 and 20 on
 Oracle Linux x86_64 (releases 7 and 8), Oracle Linux ARM (aarch64, release 8),
 Windows, and macOS.  Node-oracledb may run on other platforms, and with other
 Node.js versions, if they are `Node-API <https://nodejs.org/api/n-api.html>`__

doc/src/user_guide/objects.rst

@@ -53,18 +53,18 @@ This gives::
         name: 'SDO_GEOMETRY',
         fqn: 'MDSYS.SDO_GEOMETRY',
         attributes:
-        { 	SDO_GTYPE: { type: 2010, typeName: 'NUMBER' },
+        {   SDO_GTYPE: { type: 2010, typeName: 'NUMBER' },
             SDO_SRID: { type: 2010, typeName: 'NUMBER' },
             SDO_POINT:
-            {	type: 2023,
+            {   type: 2023,
                 typeName: 'MDSYS.SDO_POINT_TYPE',
                 typeClass: [Object] },
             SDO_ELEM_INFO:
-            { 	type: 2023,
+            {   type: 2023,
                 typeName: 'MDSYS.SDO_ELEM_INFO_ARRAY',
                 typeClass: [Object] },
             SDO_ORDINATES:
-            { 	type: 2023,
+            {   type: 2023,
                 typeName: 'MDSYS.SDO_ORDINATE_ARRAY',
                 typeClass: [Object] } },
             isCollection: false }
@@ -85,7 +85,7 @@ set that are not present in the database object will be ignored.
 .. code-block:: javascript
 
     const geom = new GeomType(
-    	{
+        {
             SDO_GTYPE: 2003,
             SDO_SRID: null,
             SDO_POINT: null,
@@ -310,7 +310,7 @@ insertion into ``mytab`` use:
         `BEGIN mypkg.myinproc(:id, :vals); END;`,
         {
             id: 1234,
-            vals: {	type: oracledb.NUMBER,
+            vals: { type: oracledb.NUMBER,
                     dir: oracledb.BIND_IN,
                     val: [1, 2, 23, 4, 10]
                 }
@@ -324,7 +324,7 @@ Alternatively, “bind by position” syntax can be used:
     `BEGIN mypkg.myinproc(:id, :vals); END;`,
     [
         1234,
-        {	type: oracledb.NUMBER,
+        {   type: oracledb.NUMBER,
             dir: oracledb.BIND_IN,
             val: [1, 2, 23, 4, 10]
         }
@@ -336,7 +336,7 @@ After executing either of these ``mytab`` will contain:
 
        ID         NUMCOL
     ---------- ----------
-    	1234          1
+        1234          1
         1234          2
         1234         23
         1234          4
@@ -400,7 +400,7 @@ With these values, the following node-oracledb code will print
         `BEGIN mypkg.myoutproc(:id, :vals); END;`,
         {
             id: 99,
-            vals: {	type: oracledb.NUMBER,
+            vals: { type: oracledb.NUMBER,
                     dir:  oracledb.BIND_OUT,
                     maxArraySize: 10          // allocate memory to hold 10 numbers
                 }

doc/src/user_guide/plsql_execution.rst

@@ -309,7 +309,7 @@ Since the code does not explicitly set ``oracledb.edition`` (or
 equivalent), then the first implementation of ``DISCOUNT`` in the
 default edition is used. The output might be like::
 
-    [ 	{ NAME: 'lamp', PRICE: 40, DISCOUNTPRICE: 36 },
+    [   { NAME: 'lamp', PRICE: 40, DISCOUNTPRICE: 36 },
         { NAME: 'wire', PRICE: 10, DISCOUNTPRICE: 6 },
         { NAME: 'switch', PRICE: 4, DISCOUNTPRICE: 1 } ]
 
@@ -330,7 +330,7 @@ If the connection uses edition ``e2``, then the second implementation of
 
 The output might be like::
 
-    [ 	{ NAME: 'lamp', PRICE: 40, DISCOUNTPRICE: 30 },
+    [   { NAME: 'lamp', PRICE: 40, DISCOUNTPRICE: 30 },
         { NAME: 'wire', PRICE: 10, DISCOUNTPRICE: 7.5 },
         { NAME: 'switch', PRICE: 4, DISCOUNTPRICE: 3 } ]
 

doc/src/user_guide/sql_execution.rst

@@ -836,24 +836,30 @@ precision.
 Fetching Dates and Timestamps
 +++++++++++++++++++++++++++++
 
-The Oracle Database DATE and TIMESTAMP columns are fetched as JavaScript date
-types in the timezone of the application. The Oracle Database TIMESTAMP WITH
-LOCAL TIME ZONE and TIMESTAMP WITH TIME ZONE columns are fetched as TIMESTAMP
-WITH LOCAL TIME ZONE. Oracle INTERVAL types are not supported. The connection
-session time zone does not affect these data types.
+Oracle Database DATE and TIMESTAMP columns are fetched as dates in the timezone
+of the application.  The TIMESTAMP WITH TIME ZONE and TIMESTAMP WITH LOCAL TIME
+ZONE columns are fetched as absolute dates.  Note that JavaScript Date has
+millisecond precision therefore timestamps will lose any sub-millisecond
+fractional part when fetched.
 
-.. versionchanged:: 6.0
-
-    Prior to this release, the DATE and TIMESTAMP columns were fetched as
-    TIMESTAMP WITH LOCAL TIME ZONE.
+Oracle INTERVAL types are not supported.
 
-Note that JavaScript Date has millisecond precision. Therefore, timestamps
-will lose any sub-millisecond fractional part when fetched.
+.. versionchanged:: 6.0
 
-To make applications more portable, it is recommended to always set the
-session time zone to a pre-determined value, such as UTC. The session
-time zone should generally match the client system time zone, for
-example the ``TZ`` environment variable or the Windows time zone region.
+    Oracle Database DATE and TIMESTAMP types are now returned as JavaScript
+    date types in the application's timezone, and no longer fetched or bound as
+    TIMESTAMP WITH LOCAL TIME ZONE.  The connection session time zone no longer
+    impacts these types.  This behavior aligns with other Oracle Database tools
+    and drivers. Handling of TIMESTAMP WITH TIMEZONE and TIMESTAMP WITH LOCAL
+    TIMEZONE has not changed.  For DATE and TIMESTAMP compatibility with
+    node-oracledb 5.5, use a :ref:`fetch type handler <fetchtypehandler>` and
+    set the return ``type`` attribute to ``oracledb.DB_TYPE_TIMESTAMP_LTZ``.
+    Also use a similar type when binding if compatibility is needed.
+
+To make applications more portable, it is recommended to set the client system
+time zone (for example the ``TZ`` environment variable or the Windows time zone
+region) to match the Oracle session time zone, and to use a pre-determined
+value, such as UTC.
 
 You can find the current session time zone with: