Remove the 'Critical Dependency' warning from webpack builds (Issue #1678

Author: sharadraju

doc/src/release_notes.rst

@@ -42,6 +42,9 @@ Common Changes
 #)  Added method :meth:`oracledb.getNetworkServiceNames()` to support fetching
     the list of network service names from the ``tnsnames.ora`` file.
 
+#) Remove the 'Critical Dependency' warning from webpack builds.
+   See `Issue #1678 <https://github.com/oracle/node-oracledb/issues/1678>`__.
+
 Thin Mode Changes
 +++++++++++++++++
 

lib/oracledb.js

@@ -74,8 +74,16 @@ let _initOracleClientArgs;
 
 // Load the Oracledb binary
 function _initCLib(options) {
+  // Ensure that webpack compile does not throw any issues or warnings
+  // See https://github.com/oracle/node-oracledb/issues/1156
+  // and https://github.com/oracle/node-oracledb/issues/1678
+  const nodeVer = typeof process !== 'undefined' && process.versions?.node;
   /*global __non_webpack_require__*/  // quieten eslint
-  const requireBinary = (typeof __non_webpack_require__ === 'function') ? __non_webpack_require__ : require; // See Issue 1156
+  const requireBinary = nodeVer
+    ? (typeof __webpack_require__ === 'function')
+      ? __non_webpack_require__
+      : require
+    : undefined;
   const binaryLocations = [
     '../' + nodbUtil.RELEASE_DIR + '/' + nodbUtil.BINARY_FILE,  // pre-built binary
     '../' + nodbUtil.RELEASE_DIR + '/' + nodbUtil.BUILD_FILE,   // binary built from source