Add proper error message when empty connect string is provided for creating connection pools

Author: sharadraju

doc/src/release_notes.rst

@@ -50,6 +50,9 @@ Thin Mode Changes
 #)  Added new properties in `oracledb` that can enable users to customize and set session information,
     making it easier to manage and monitor database interactions.
 
+#)  Error ``NJS-125`` is now raised when an empty connect string is provided
+    for creating pools.
+
 Thick Mode changes
 ++++++++++++++++++
 

lib/thin/pool.js

@@ -44,6 +44,9 @@ class ThinPoolImpl extends PoolImpl {
     if (!params.homogeneous) {
       errors.throwErr(errors.ERR_NOT_IMPLEMENTED, 'Heterogeneous Pooling');
     }
+    if (!params.connectString) {
+      errors.throwErr(errors.ERR_EMPTY_CONNECT_STRING);
+    }
     thinUtil.checkCredentials(params);
 
     this._availableObjects = [];

test/list.txt

@@ -80,8 +80,9 @@ Overview of node-oracledb functional tests
         2.11.2 error occurs at getConnection() when poolMin is the default value 0
     2.12 connectionString alias
         2.12.1 allows connectionString to be used as an alias for connectString
-    2.13 connectString & connectionString provided
+    2.13 connect string
         2.13.1 both connectString & connectionString provided
+        2.13.2 Negative - empty connect string
     2.14 username alias
         2.14.1 allows username to be used as an alias for user
         2.14.2 both user and username specified

test/pool.js

@@ -616,7 +616,7 @@ describe('2. pool.js', function() {
     });
   }); // 2.12
 
-  describe('2.13 connectString & connectionString provided', function() {
+  describe('2.13 connect string', function() {
 
     it('2.13.1 both connectString & connectionString provided', async function() {
       const config = {...dbConfig,
@@ -630,6 +630,21 @@ describe('2. pool.js', function() {
         /NJS-075:/
       );
     });  // 2.13.1
+
+    it('2.13.2 Negative - empty connect string', async function() {
+      const config = {...dbConfig,
+        connectString: dbConfig.connectString_does_not_exist,
+        poolMin: 1,
+        poolMax: 1,
+        poolIncrement: 0
+      };
+      await assert.rejects(
+        async () => await oracledb.createPool(config),
+        /ORA-01017:|NJS-125:/
+        // ORA-01017: invalid username/password; logon denied
+        // NJS-125: "connectString" cannot be empty or undefined. Bequeath connections are not supported in Thin mode
+      );
+    });  // 2.13.2
   });  // 2.13
 
   describe('2.14 username alias', function() {