Internal Code optimizations

Author: sharadraju

lib/connection.js

@@ -206,7 +206,7 @@ class Connection extends EventEmitter {
       value instanceof Float64Array ||
       value instanceof Int8Array ||
       Buffer.isBuffer(value) ||
-      util.isDate(value) ||
+      util.types.isDate(value) ||
       value instanceof Lob ||
       value instanceof ResultSet ||
       value instanceof BaseDbObject

lib/impl/connection.js

@@ -111,7 +111,7 @@ class ConnectionImpl {
   // removed once Node-API version 5 is used in the C extension.
   // ---------------------------------------------------------------------------
   _isDate(val) {
-    return (util.isDate(val));
+    return (util.types.isDate(val));
   }
 
   //---------------------------------------------------------------------------

lib/impl/datahandlers/oson.js

@@ -564,7 +564,7 @@ class OsonTreeSegment extends GrowableBuffer {
       }
 
     // handle dates
-    } else if (util.isDate(value)) {
+    } else if (util.types.isDate(value)) {
       if (value.getUTCMilliseconds() === 0) {
         this.writeUInt8(constants.TNS_JSON_TYPE_TIMESTAMP7);
         this.writeOracleDate(value, types.DB_TYPE_DATE, false);

lib/thin/protocol/protocol.js

@@ -71,7 +71,7 @@ class Protocol {
     while (true) {     // eslint-disable-line
       if (this.nsi.isBreak) {
         await this.resetMessage();
-        delete this.readBuf.savedBuffers;
+        delete this.readBuf.savedPackets;
         await this.readBuf.waitForPackets();
       }
       try {

lib/transformer.js

@@ -89,7 +89,7 @@ function transformJsonValue(value) {
   if (value === undefined || value === null ||
     typeof value === 'number' || typeof value === 'string' ||
     typeof value === 'boolean' || Buffer.isBuffer(value) ||
-    util.isDate(value) || nodbUtil.isVectorValue(value))
+    util.types.isDate(value) || nodbUtil.isVectorValue(value))
     return value;
 
   // arrays are transformed to a new array with processed values
@@ -189,7 +189,7 @@ function transformValueIn(info, value, options) {
     return value;
 
   // handle dates
-  } else if (util.isDate(value)) {
+  } else if (util.types.isDate(value)) {
     checkType(info, options,
       types.DB_TYPE_TIMESTAMP,
       types.DB_TYPE_TIMESTAMP_TZ,

lib/util.js

@@ -231,7 +231,7 @@ function isShardingKey(value) {
     const element = value[i];
     const ok = typeof element === 'string' ||
       typeof element === 'number' || Buffer.isBuffer(element) ||
-      util.isDate(element);
+      util.types.isDate(element);
     if (!ok)
       return false;
   }