add maxRow 200 test case

Author: Christopher Jones

test/binding.js

@@ -38,6 +38,7 @@ var oracledb = require('oracledb');
 var should = require('should');
 var async = require('async');
 var dbConfig = require('./dbConfig.js');
+var assist = require('./dataTypeAssist.js');
 
 describe('4. binding.js', function() {
 
@@ -662,20 +663,32 @@ describe('4. binding.js', function() {
       ], done);
     })
 
-    it.skip('4.4.2 default value is 200', function(done) {
+    it('4.4.2 default value is 200', function(done) {
+      connection.execute(
+        "BEGIN :o := lpad('A', 200, 'x'); END;",
+        { o: { type: oracledb.STRING, dir: oracledb.BIND_OUT } },
+        function(err, result) {
+          should.not.exist(err);
+          (result.outBinds.o.length).should.be.exactly(200);
+          done();
+        }
+      );
+    })
+
+    it.skip('4.4.3 Negative - bind out data exceeds default length', function(done) {
       connection.execute(
         "BEGIN :o := lpad('A',201,'x'); END;", 
          { o: { type: oracledb.STRING, dir : oracledb.BIND_OUT } }, 
          function (err, result) { 
            should.exist(err);
            err.message.should.startWith('ORA-06502:');
-           console.log(result.outBinds.o.length); 
+           // console.log(result.outBinds.o.length); 
            done();
          }
       );
     })
 
-    it.skip('4.4.3 maximum value is 32767', function(done) {
+    it.skip('4.4.4 maximum value is 32767', function(done) {
       connection.execute(
         "BEGIN :o := lpad('A',32767,'x'); END;", 
         { o: { type: oracledb.STRING, dir : oracledb.BIND_OUT, maxSize:50000 } },
@@ -686,5 +699,51 @@ describe('4. binding.js', function() {
         }
       );
     })
-  })  
+  }) // 4.4 
+
+  describe.skip('4.5 The default direction for binding is BIND_IN', function() {
+    var connection = null;
+    var tableName = "oracledb_raw";
+
+    before(function(done) {
+      oracledb.getConnection(credential, function(err, conn) {
+        if(err) { console.error(err.message); return; }
+        connection = conn;
+        assist.createTable(connection, tableName, done);
+      });
+    })
+  
+    after(function(done) {
+      async.series([
+        function(callback) {
+          connection.execute(
+            "DROP TABLE " + tableName,
+            function(err) {
+              should.not.exist(err);
+              callback();
+            }
+          );
+        },
+        function(callback) {
+          connection.release( function(err) {
+            should.not.exist(err);
+            callback();
+          });
+        }
+      ], done);
+    })
+
+    
+    it('4.5.1',function(done) {
+      connection.execute(
+        "insert into oracledb_raw (num) values (:id)",
+        { id: { val: 1, type: oracledb.NUMBER } },  // fails with error  NJS-013: invalid bind direction
+        // { id: { val: 1, type: oracledb.NUMBER, dir: oracledb.BIND_IN } }, // works
+        function(err, result) {
+          should.not.exist(err);
+          done();
+        }
+      );
+    })
+  }) // 4.5
 })

test/dataTypeRaw.js

@@ -31,7 +31,7 @@
  *     51 -     are for other tests  
  * 
  *****************************************************************************/
- "use strict";
+"use strict";
 
 var oracledb = require('oracledb');
 var should = require('should');
@@ -47,7 +47,7 @@ describe('42. dataTypeRaw.js', function() {
     var credential = dbConfig;
   }
 
-  var connection = false;
+  var connection = null;
   var tableName = "oracledb_raw";
 
   var bufLen = [10 ,100, 1000, 2000]; // buffer length
@@ -98,6 +98,35 @@ describe('42. dataTypeRaw.js', function() {
       assist.verifyRefCursor(connection, tableName, bufs, done);
     })
 
+    it('42.1.4 result set getRow() function works well with RAW', function(done) {
+      
+      var sql1 = "select dummy, HEXTORAW('0123456789ABCDEF0123456789ABCDEF') from dual";
+      connection.execute(
+        sql1,
+        [], 
+        { resultSet: true },
+        function(err, result) {
+          should.not.exist(err);
+          fetchOneRowFromRS(result.resultSet, done);
+        }
+      );
+
+      function fetchOneRowFromRS(rs, cb)
+      {
+        rs.getRow(function(err, row) {
+          should.not.exist(err);
+          if(row) {
+            fetchOneRowFromRS(rs, cb);
+          } else {
+            rs.close( function(err) {
+              should.not.exist(err);
+              cb();
+            });
+          }
+        });
+      }
+    })
+
   })
 
   describe('42.2 stores null value correctly', function() {

test/list.txt

@@ -93,8 +93,11 @@
         4.3.4 should pass but fail in array syntax with returning into
     4.4 test maxSize option
         4.4.1 outBind & maxSize restriction
-      - 4.4.2 default value is 200
-      - 4.4.3 maximum value is 32767
+        4.4.2 default value is 200
+      - 4.4.3 Negative - bind out data exceeds default length
+      - 4.4.4 maximum value is 32767
+    4.5 The default direction for binding is BIND_IN
+      - 4.5.1
 
 5. externalAuthentication.js
     5.1 connection should succeed when setting externalAuth to be false and providing user/password
@@ -404,9 +407,8 @@
         55.9.1 
     55.10 calls getRows() once and then close RS before getting more rows
         55.10.1 
-    55.11 deals with unsupported database with result set
-        55.11.1 RAW data type
-        55.11.2 ROWID date type
+    55.11 result set with unsupported data types
+        55.11.1 ROWID data type
     55.12 bind a cursor BIND_INOUT
       - 55.12.1 should work
 

test/resultSet2.js

@@ -749,8 +749,8 @@ describe('55. resultSet2.js', function() {
     })
   })
 
-  describe('55.11 deals with unsupported database with result set', function() {
-    var sql1 = "select dummy, HEXTORAW('0123456789ABCDEF0123456789ABCDEF') from dual";
+  describe('55.11 result set with unsupported data types', function() {
+    
     var sql2 = "SELECT dummy, rowid FROM dual";
 
     function fetchOneRowFromRS(rs, cb) {
@@ -759,6 +759,7 @@ describe('55. resultSet2.js', function() {
          * the result set can still be created.
          */ 
         // Error at accessing RS
+        should.exist(err);
         if(err) {
           // console.error("Error at accessing RS: " + err.message); 
           // NJS-010: unsupported data type in select list
@@ -779,20 +780,7 @@ describe('55. resultSet2.js', function() {
       });
     }
 
-    it('55.11.1 RAW data type', function(done) {
-      connection.should.be.ok;
-      connection.execute(
-        sql1,
-        [],
-        { resultSet: true },
-        function(err, result) {
-          should.not.exist(err);
-          fetchOneRowFromRS(result.resultSet, done);
-        }
-      );       
-    })
-
-    it('55.11.2 ROWID date type', function(done) {
+    it('55.11.1 ROWID date type', function(done) {
       connection.execute(
         sql2,
         [],