Remove Strings.fromNumber.

Author: woess

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/JSRuntime.java

@@ -1566,9 +1566,20 @@ public static boolean isHex(char c) {
 
     @TruffleBoundary
     public static long parseArrayIndexIsIndexRaw(Object o) {
-        assert isArrayIndex(o);
-        assert Strings.isTString(o) || o instanceof Number;
-        return parseArrayIndexRaw(o instanceof TruffleString str ? str : Strings.fromNumber((Number) o), TruffleString.ReadCharUTF16Node.getUncached());
+        assert (Strings.isTString(o) || o instanceof Number) && isArrayIndex(o) : o;
+        TruffleString asStr;
+        if (o instanceof TruffleString str) {
+            asStr = str;
+        } else if (o instanceof Integer i) {
+            return i;
+        } else if (o instanceof Long l) {
+            return l;
+        } else if (o instanceof Double d) {
+            asStr = doubleToString(d);
+        } else {
+            throw CompilerDirectives.shouldNotReachHere();
+        }
+        return parseArrayIndexRaw(asStr, TruffleString.ReadCharUTF16Node.getUncached());
     }
 
     /**

graal-js/src/com.oracle.truffle.js/src/com/oracle/truffle/js/runtime/Strings.java

@@ -44,7 +44,6 @@
 import java.util.ArrayList;
 import java.util.Locale;
 
-import com.oracle.truffle.api.CompilerDirectives;
 import com.oracle.truffle.api.CompilerDirectives.TruffleBoundary;
 import com.oracle.truffle.api.interop.InteropLibrary;
 import com.oracle.truffle.api.interop.UnsupportedMessageException;
@@ -848,28 +847,6 @@ public static TruffleString fromInt(int intValue) {
         return fromLong(intValue);
     }
 
-    public static TruffleString fromDouble(double d) {
-        return TruffleString.FromJavaStringNode.getUncached().execute(doubleToJavaString(d), TruffleString.Encoding.UTF_16);
-    }
-
-    @TruffleBoundary
-    private static String doubleToJavaString(double d) {
-        return String.valueOf(d);
-    }
-
-    public static TruffleString fromNumber(Number number) {
-        if (number instanceof Integer) {
-            return fromInt(number.intValue());
-        }
-        if (number instanceof Long) {
-            return fromLong(number.longValue());
-        }
-        if (number instanceof Double) {
-            return fromDouble(number.doubleValue());
-        }
-        throw CompilerDirectives.shouldNotReachHere();
-    }
-
     @TruffleBoundary
     public static TruffleString fromBigInt(BigInt bi) {
         return fromBigInt(TruffleString.FromJavaStringNode.getUncached(), bi);