Fixed multiple issues related to materialized view

Author: aosingh

dbt/adapters/oracle/relation.py

@@ -39,6 +39,10 @@
     OracleQuotePolicy,
     OracleIncludePolicy)
 
+from dbt.events import AdapterLogger
+
+logger = AdapterLogger("oracle")
+
 
 @dataclass(frozen=True, eq=False, repr=False)
 class OracleRelation(BaseRelation):
@@ -80,30 +84,32 @@ def materialized_view_config_changeset(
         assert isinstance(existing_materialized_view, OracleMaterializedViewConfig)
         assert isinstance(new_materialized_view, OracleMaterializedViewConfig)
 
-        if new_materialized_view.refresh_method != existing_materialized_view.refresh_method:
+        if new_materialized_view.refresh_method.upper() != existing_materialized_view.refresh_method.upper():
             config_change_collection.refresh_method = OracleRefreshMethodConfigChange(
                 action=RelationConfigChangeAction.alter,
                 context=new_materialized_view.refresh_method
             )
 
-        if new_materialized_view.refresh_mode != existing_materialized_view.refresh_method:
+        if new_materialized_view.refresh_mode.upper() != existing_materialized_view.refresh_mode.upper():
             config_change_collection.refresh_mode = OracleRefreshModeConfigChange(
                 action=RelationConfigChangeAction.alter,
                 context=new_materialized_view.refresh_mode
             )
 
-        if new_materialized_view.build_mode != existing_materialized_view.build_mode:
+        if new_materialized_view.build_mode.upper() != existing_materialized_view.build_mode.upper():
             config_change_collection.build_mode = OracleBuildModeConfigChange(
                 action=RelationConfigChangeAction.alter,
                 context=new_materialized_view.build_mode
             )
 
-        if new_materialized_view.query_rewrite != existing_materialized_view.query_rewrite:
+        if new_materialized_view.query_rewrite.upper() != existing_materialized_view.query_rewrite.upper():
             config_change_collection.query_rewrite = OracleQueryRewriteConfigChange(
                 action=RelationConfigChangeAction.alter,
                 context=new_materialized_view.query_rewrite
             )
 
+        logger.debug(f"Config change collection {config_change_collection}")
+
         if config_change_collection.has_changes:
 
             if config_change_collection.refresh_mode is None:
@@ -128,4 +134,6 @@ def materialized_view_config_changeset(
 
             return config_change_collection
 
+
+
         return None

dbt/adapters/oracle/relation_configs/materialized_view.py

@@ -25,7 +25,9 @@
 
 from dbt.contracts.graph.nodes import ModelNode
 from dbt.exceptions import DbtRuntimeError
+from dbt.events import AdapterLogger
 
+logger = AdapterLogger("oracle")
 
 @dataclass(frozen=True, eq=True, unsafe_hash=True)
 class OracleMaterializedViewConfig(OracleRelationConfigBase):
@@ -107,14 +109,16 @@ def parse_relation_results(cls, relation_results: RelationResults) -> dict:
         """
 
         materialized_view: agate.Row = cls._get_first_row(relation_results.get("materialized_view"))
+        logger.debug(f"Materialized View data is {materialized_view}")
         config_dict = {
-            "mview_name": materialized_view.get("mview_name"),
-            "refresh_mode": materialized_view.get("refresh_mode"),
-            "refresh_method": materialized_view.get("refresh_method"),
-            "build_mode": materialized_view.get("build_mode"),
-            "query": materialized_view.get("query"),
+            "mview_name": materialized_view.get("mview_name".upper()),
+            "refresh_mode": materialized_view.get("refresh_mode".upper()),
+            "refresh_method": materialized_view.get("refresh_method".upper()),
+            "build_mode": materialized_view.get("build_mode".upper()),
+            "query": materialized_view.get("query".upper()),
         }
-        if materialized_view.get('rewrite_enabled').upper() == 'Y':
+        logger.debug(f"Materialized View config is {config_dict}")
+        if materialized_view.get('rewrite_enabled'.upper()).upper() == 'Y':
             config_dict["query_rewrite"] = "enable"
         else:
             config_dict["query_rewrite"] = "disable"

dbt/include/oracle/macros/adapters.sql

@@ -380,6 +380,7 @@
            else 'BASE TABLE'
          end table_type
        from sys.all_tables
+       where upper(table_name) not in (select upper(mview_name) from sys.all_mviews)
        union all
        select SYS_CONTEXT('userenv', 'DB_NAME'),
          owner,

dbt/include/oracle/macros/catalog.sql

@@ -82,6 +82,7 @@
                      else 'BASE TABLE'
                    end table_type
                  from sys.all_tables
+                 where upper(table_name) not in (select upper(mview_name) from sys.all_mviews) 
                  union all
                  select SYS_CONTEXT('userenv', 'DB_NAME'),
                    owner,

dbt/include/oracle/macros/materializations/materialized_view/materialized_view.sql

@@ -12,6 +12,7 @@
     {% call statement(name="drop_mv") %}
         {{ oracle__drop_relation(relation) }}
     {% endcall %}
+    {{- log('ORACLE Applying REPLACE to: ' ~ relation) -}}
     {{ get_create_materialized_view_as_sql(relation, sql) }}
 {% endmacro %}
 
@@ -56,7 +57,7 @@
 {% endmacro %}
 
 {% macro oracle__get_materialized_view_configuration_changes(existing_relation, new_config) %}
-    {% set _existing_materialized_view = oracle__describe_materialized_view(existing_relation) %}
+    {% set _existing_materialized_view = oracle__describe_materialized_view_config(existing_relation) %}
     {% set _configuration_changes = existing_relation.materialized_view_config_changeset(_existing_materialized_view, new_config) %}
     {% do return(_configuration_changes) %}
 {% endmacro %}