Fix unit tests

Author: esrakartalOpt

lib/optimizely/config/datafile_project_config.rb

@@ -123,6 +123,9 @@ def initialize(datafile, logger, error_handler)
       @holdouts.each do |holdout|
         next unless holdout['status'] == 'Running'
 
+        # Ensure holdout has layerId field (holdouts don't have campaigns)
+        holdout['layerId'] ||= ''
+
         @holdout_id_map[holdout['id']] = holdout
 
         included_flags = holdout['includedFlags'] || []

spec/config/datafile_project_config_spec.rb

@@ -1250,7 +1250,8 @@
     end
 
     it 'should return global holdouts that do not exclude the flag' do
-      holdouts = config_with_holdouts.get_holdouts_for_flag('multi_variate_feature')
+      multi_variate_feature_id = '155559'
+      holdouts = config_with_holdouts.get_holdouts_for_flag(multi_variate_feature_id)
       expect(holdouts.length).to eq(3)
 
       global_holdout = holdouts.find { |h| h['key'] == 'global_holdout' }
@@ -1263,22 +1264,25 @@
     end
 
     it 'should not return global holdouts that exclude the flag' do
-      holdouts = config_with_holdouts.get_holdouts_for_flag('boolean_single_variable_feature')
+      boolean_feature_id = '155554'
+      holdouts = config_with_holdouts.get_holdouts_for_flag(boolean_feature_id)
       expect(holdouts.length).to eq(1)
 
       global_holdout = holdouts.find { |h| h['key'] == 'global_holdout' }
       expect(global_holdout).to be_nil
     end
 
     it 'should cache results for subsequent calls' do
-      holdouts1 = config_with_holdouts.get_holdouts_for_flag('multi_variate_feature')
-      holdouts2 = config_with_holdouts.get_holdouts_for_flag('multi_variate_feature')
+      multi_variate_feature_id = '155559'
+      holdouts1 = config_with_holdouts.get_holdouts_for_flag(multi_variate_feature_id)
+      holdouts2 = config_with_holdouts.get_holdouts_for_flag(multi_variate_feature_id)
       expect(holdouts1).to equal(holdouts2)
       expect(holdouts1.length).to eq(3)
     end
 
     it 'should return only global holdouts for flags not specifically targeted' do
-      holdouts = config_with_holdouts.get_holdouts_for_flag('string_single_variable_feature')
+      string_feature_id = '594060'
+      holdouts = config_with_holdouts.get_holdouts_for_flag(string_feature_id)
 
       # Should only include global holdout (not excluded and no specific targeting)
       expect(holdouts.length).to eq(2)
@@ -1394,7 +1398,7 @@
 
     it 'should properly categorize holdouts during initialization' do
       expect(config_with_complex_holdouts.holdout_id_map.keys).to contain_exactly('global_holdout', 'specific_holdout')
-      expect(config_with_complex_holdouts.global_holdouts.keys).to contain_exactly('global_holdout')
+      expect(config_with_complex_holdouts.global_holdouts.map { |h| h['id'] }).to contain_exactly('global_holdout')
 
       # Use the correct feature flag IDs
       boolean_feature_id = '155554'
@@ -1416,7 +1420,7 @@
 
     it 'should only process running holdouts during initialization' do
       expect(config_with_complex_holdouts.holdout_id_map['inactive_holdout']).to be_nil
-      expect(config_with_complex_holdouts.global_holdouts['inactive_holdout']).to be_nil
+      expect(config_with_complex_holdouts.global_holdouts.find { |h| h['id'] == 'inactive_holdout' }).to be_nil
 
       boolean_feature_id = '155554'
       included_for_boolean = config_with_complex_holdouts.included_holdouts[boolean_feature_id]
@@ -1594,7 +1598,7 @@
 
       it 'should handle mixed holdout configurations' do
         # Verify the config has properly categorized holdouts
-        expect(config_with_holdouts.global_holdouts).to be_a(Hash)
+        expect(config_with_holdouts.global_holdouts).to be_a(Array)
         expect(config_with_holdouts.included_holdouts).to be_a(Hash)
         expect(config_with_holdouts.excluded_holdouts).to be_a(Hash)
       end
@@ -1774,7 +1778,7 @@
       config = Optimizely::DatafileProjectConfig.new(config_json, logger, error_handler)
 
       # Should treat as global holdout
-      expect(config.global_holdouts['holdout_nil']).not_to be_nil
+      expect(config.global_holdouts.find { |h| h['id'] == 'holdout_nil' }).not_to be_nil
     end
 
     it 'should only include running holdouts in maps' do