Fix config tests for holdout entity changes

- Add required fields (variations, trafficAllocation, audienceIds) to holdout test configs
- Fix BaseEntity __eq__ to handle comparisons with non-entity types
- Fix test assertion to check for holdout IDs in global_holdouts list
- All 86 config tests passing
- All 12 holdout config tests passing

Author: muzahidul-opti

.claude/settings.local.json

@@ -15,7 +15,9 @@
       "Bash(python3 -c \"from optimizely import bucketer; print(''bucketer.py imports successfully'')\")",
       "Bash(python3 -m mypy optimizely/entities.py --no-error-summary)",
       "Bash(python3 -m unittest tests.test_decision_service_holdout)",
-      "Bash(python3 -m unittest discover tests -p \"test_*.py\" -v)"
+      "Bash(python3 -m unittest discover tests -p \"test_*.py\" -v)",
+      "Bash(git add -A)",
+      "Bash(git commit -m \"Fix config tests for holdout entity changes\n\n- Add required fields (variations, trafficAllocation, audienceIds) to holdout test configs\n- Fix BaseEntity __eq__ to handle comparisons with non-entity types\n- Fix test assertion to check for holdout IDs in global_holdouts list\n- All 86 config tests passing\n- All 12 holdout config tests passing\")"
     ]
   }
 }

optimizely/entities.py

@@ -27,6 +27,8 @@
 
 class BaseEntity:
     def __eq__(self, other: object) -> bool:
+        if not hasattr(other, '__dict__'):
+            return False
         return self.__dict__ == other.__dict__
 
 

tests/test_config.py

@@ -1393,20 +1393,29 @@ def setUp(self):
                 'id': 'holdout_1',
                 'key': 'global_holdout',
                 'status': 'Running',
+                'variations': [],
+                'trafficAllocation': [],
+                'audienceIds': [],
                 'includedFlags': [],
                 'excludedFlags': [boolean_feature_id]
             },
             {
                 'id': 'holdout_2',
                 'key': 'specific_holdout',
                 'status': 'Running',
+                'variations': [],
+                'trafficAllocation': [],
+                'audienceIds': [],
                 'includedFlags': [multi_variate_feature_id],
                 'excludedFlags': []
             },
             {
                 'id': 'holdout_3',
                 'key': 'inactive_holdout',
                 'status': 'Inactive',
+                'variations': [],
+                'trafficAllocation': [],
+                'audienceIds': [],
                 'includedFlags': [boolean_feature_id],
                 'excludedFlags': []
             }
@@ -1512,7 +1521,9 @@ def test_holdout_initialization__categorizes_holdouts_properly(self):
 
         self.assertIn('holdout_1', self.config_with_holdouts.holdout_id_map)
         self.assertIn('holdout_2', self.config_with_holdouts.holdout_id_map)
-        self.assertIn('holdout_1', self.config_with_holdouts.global_holdouts)
+        # Check if a holdout with ID 'holdout_1' exists in global_holdouts
+        holdout_ids_in_global = [h.id for h in self.config_with_holdouts.global_holdouts]
+        self.assertIn('holdout_1', holdout_ids_in_global)
 
         # Use correct feature flag IDs
         boolean_feature_id = '91111'