fix: skip identify on user_context clone (#409)

Author: andrewleap-optimizely

optimizely/optimizely_user_context.py

@@ -37,8 +37,12 @@ class OptimizelyUserContext:
     """
 
     def __init__(
-        self, optimizely_client: optimizely.Optimizely, logger: Logger,
-        user_id: str, user_attributes: Optional[UserAttributes] = None
+        self,
+        optimizely_client: optimizely.Optimizely,
+        logger: Logger,
+        user_id: str,
+        user_attributes: Optional[UserAttributes] = None,
+        identify: bool = True
     ):
         """ Create an instance of the Optimizely User Context.
 
@@ -47,6 +51,7 @@ def __init__(
           logger: logger for logging
           user_id: user id of this user context
           user_attributes: user attributes to use for this user context
+          identify: True to send identify event to ODP.
 
         Returns:
           UserContext instance
@@ -67,7 +72,7 @@ def __init__(
             OptimizelyUserContext.OptimizelyForcedDecision
         ] = {}
 
-        if self.client:
+        if self.client and identify:
             self.client.identify_user(user_id)
 
     class OptimizelyDecisionContext:
@@ -94,7 +99,13 @@ def _clone(self) -> Optional[OptimizelyUserContext]:
         if not self.client:
             return None
 
-        user_context = OptimizelyUserContext(self.client, self.logger, self.user_id, self.get_user_attributes())
+        user_context = OptimizelyUserContext(
+            self.client,
+            self.logger,
+            self.user_id,
+            self.get_user_attributes(),
+            identify=False
+        )
 
         with self.lock:
             if self.forced_decisions_map:

tests/test_user_context.py

@@ -2021,6 +2021,24 @@ def test_send_identify_event_when_user_context_created(self):
         mock_logger.error.assert_not_called()
         client.close()
 
+    def test_identify_is_skipped_with_decisions(self):
+        mock_logger = mock.Mock()
+        client = optimizely.Optimizely(json.dumps(self.config_dict_with_features), logger=mock_logger)
+        with mock.patch.object(client, 'identify_user') as identify:
+            user_context = OptimizelyUserContext(client, mock_logger, 'user-id')
+
+        identify.assert_called_once_with('user-id')
+        mock_logger.error.assert_not_called()
+
+        with mock.patch.object(client, 'identify_user') as identify:
+            user_context.decide('test_feature_in_rollout')
+            user_context.decide_all()
+            user_context.decide_for_keys(['test_feature_in_rollout'])
+
+        identify.assert_not_called()
+        mock_logger.error.assert_not_called()
+        client.close()
+
     # fetch qualified segments
     def test_fetch_segments(self):
         mock_logger = mock.Mock()