fix(linter): Fixed golangci-lint implementations (#117)

Author: yasirfolio3

.travis.yml

@@ -20,9 +20,9 @@ jobs:
   include:
     - stage: 'Lint'
       install:
-        - go get github.com/golangci/golangci-lint/cmd/golangci-lint
+        - curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(go env GOPATH)/bin v1.19.0
       script:
-        - golangci-lint run --out-format=tab --tests=false optimizely/...
+        - $GOPATH/bin/golangci-lint run --out-format=tab --tests=false optimizely/...
     - stage: 'Integration Tests'
       merge_mode: replace
       env: SDK=go
@@ -34,4 +34,4 @@ jobs:
       script:
         - "$HOME/travisci-tools/fsc-trigger/trigger_fullstack-sdk-compat.sh"
       after_success: travis_terminate 0
-
+      

optimizely/notification/manager.go

@@ -18,9 +18,14 @@
 package notification
 
 import (
+	"fmt"
 	"sync/atomic"
+
+	"github.com/optimizely/go-sdk/optimizely/logging"
 )
 
+var managerLogger = logging.GetLogger("NotificationManager")
+
 // Manager is a generic interface for managing notifications of a particular type
 type Manager interface {
 	Add(func(interface{})) (int, error)
@@ -53,7 +58,10 @@ func (am *AtomicManager) Remove(id int) {
 	handlerID := uint32(id)
 	if _, ok := am.handlers[handlerID]; ok {
 		delete(am.handlers, handlerID)
+		return
 	}
+	managerLogger.Debug(fmt.Sprintf("Handler for id:%d not found", id))
+
 }
 
 // Send sends the notification to the registered handlers

optimizely/notification/manager_test.go

@@ -46,4 +46,7 @@ func TestAtomicManager(t *testing.T) {
 	atomicManager.Remove(result2)
 	atomicManager.Send(payload)
 	mockReceiver.AssertNumberOfCalls(t, "handleBetter", 2)
+
+	// Sanity check by calling remove with a incorrect handler id
+	atomicManager.Remove(55)
 }