Feature/call listener on error (#151)

* fix bug where if there was a problem with the datafile, we are not calling onStart.  Always call onStart even if there was an issue so that the app can respond

* added findbugs for crash on API 17.

* refactor 'fix'.  the stop should not call onStart.  It is cleanup after onStart has been called.

* remove weird extra space.

Author: thomaszurkan-optimizely

android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyManager.java

@@ -362,6 +362,10 @@ public void onStartComplete(UserProfileService userProfileService) {
             }
         } catch (Exception e) {
             logger.error("Unable to build OptimizelyClient instance", e);
+            if (optimizelyStartListener != null) {
+                logger.info("Sending Optimizely instance to listener may be null on failure");
+                optimizelyStartListener.onStart(optimizelyClient);
+            }
         } catch (Error e) {
             logger.error("Unable to build OptimizelyClient instance", e);
         }

datafile-handler/src/main/java/com/optimizely/ab/android/datafile_handler/DatafileLoader.java

@@ -166,7 +166,15 @@ protected void onPostExecute(@Nullable String dataFile) {
             if (dataFile == null || !dataFile.isEmpty()) {
                 datafileLoader.notify(datafileLoadedListener, dataFile);
             }
+
             datafileService.stop();
+
+            if (datafileLoader.hasNotifiedListener) {
+                // we're done here. meaning, we have notified you of either the cache coming in or of a new file.
+                // so, we are notifying you that the data file service has stopped.
+                datafileLoadedListener.onStop(datafileService.getApplicationContext());
+            }
+
         }
     }
 }

shared/build.gradle

@@ -56,6 +56,7 @@ dependencies {
     compile "com.optimizely.ab:core-api:$java_core_ver"
     compile "com.google.code.gson:gson:$gson_ver"
     compile "com.android.support.test.espresso:espresso-idling-resource:$espresso_ver"
+    compile group: 'com.google.code.findbugs', name: 'jsr305', version: '2.0.1'
     provided "com.android.support:support-annotations:$support_annotations_ver"
 
     testCompile "junit:junit:$junit_ver"