Problem
.versionrc.json has a postbump script that references sync-native-versions.js:
"scripts": {
"postbump": "node scripts/sync-native-versions.js"
}
But the file only exists as scripts/sync-native-versions.ts. The .js variant does not exist.
Impact
Currently low impact because the npm version lifecycle hook in package.json correctly runs the .ts version via node-ts.js wrapper:
"version": "node scripts/node-ts.js scripts/sync-native-versions.ts && git add package.json crates/codegraph-core/Cargo.toml"
The .versionrc.json postbump is both redundant (npm lifecycle already handles the sync) and broken (references a non-existent .js file). If commit-and-tag-version ever changes execution order or the npm lifecycle hook is removed, the version sync would silently fail.
Fix
Either:
- Remove the
postbump from .versionrc.json since the npm version lifecycle already handles it, or
- Update it to
node scripts/node-ts.js scripts/sync-native-versions.ts
Found during review of #822.
Problem
.versionrc.jsonhas apostbumpscript that referencessync-native-versions.js:But the file only exists as
scripts/sync-native-versions.ts. The.jsvariant does not exist.Impact
Currently low impact because the npm
versionlifecycle hook inpackage.jsoncorrectly runs the.tsversion vianode-ts.jswrapper:The
.versionrc.jsonpostbumpis both redundant (npm lifecycle already handles the sync) and broken (references a non-existent.jsfile). Ifcommit-and-tag-versionever changes execution order or the npm lifecycle hook is removed, the version sync would silently fail.Fix
Either:
postbumpfrom.versionrc.jsonsince the npmversionlifecycle already handles it, ornode scripts/node-ts.js scripts/sync-native-versions.tsFound during review of #822.