Move standard library imports into a type-checking block

ogenstad · ogenstad · commit dfcbc825ca7a · 2026-01-27T08:19:31.000+01:00
diff --git a/infrahub_sdk/async_typer.py b/infrahub_sdk/async_typer.py
@@ -2,12 +2,14 @@
 
 import asyncio
 import inspect
-from collections.abc import Callable
 from functools import partial, wraps
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 from typer import Typer
 
+if TYPE_CHECKING:
+    from collections.abc import Callable
+
 
 class AsyncTyper(Typer):
     @staticmethod
diff --git a/infrahub_sdk/batch.py b/infrahub_sdk/batch.py
@@ -1,12 +1,13 @@
 from __future__ import annotations
 
 import asyncio
-from collections.abc import AsyncGenerator, Awaitable, Callable, Generator
 from concurrent.futures import ThreadPoolExecutor
 from dataclasses import dataclass
 from typing import TYPE_CHECKING, Any
 
 if TYPE_CHECKING:
+    from collections.abc import AsyncGenerator, Awaitable, Callable, Generator
+
     from .node import InfrahubNode, InfrahubNodeSync
 
 
diff --git a/infrahub_sdk/client.py b/infrahub_sdk/client.py
@@ -5,8 +5,6 @@
 import logging
 import time
 import warnings
-from collections.abc import Callable, Coroutine, Mapping, MutableMapping
-from datetime import datetime
 from functools import wraps
 from time import sleep
 from typing import (
@@ -61,6 +59,8 @@
 from .utils import decode_json, get_user_permissions, is_valid_uuid
 
 if TYPE_CHECKING:
+    from collections.abc import Callable, Coroutine, Mapping, MutableMapping
+    from datetime import datetime
     from types import TracebackType
 
     from httpx._transports.base import AsyncBaseTransport, BaseTransport
diff --git a/infrahub_sdk/ctl/cli_commands.py b/infrahub_sdk/ctl/cli_commands.py
@@ -7,7 +7,6 @@
 import logging
 import platform
 import sys
-from collections.abc import Callable
 from pathlib import Path
 from typing import TYPE_CHECKING, Any
 
@@ -56,6 +55,8 @@
 from .parameters import CONFIG_PARAM
 
 if TYPE_CHECKING:
+    from collections.abc import Callable
+
     from ..schema.repository import InfrahubRepositoryConfig
 
 app = AsyncTyper(pretty_exceptions_show_locals=False)
diff --git a/infrahub_sdk/ctl/graphql.py b/infrahub_sdk/ctl/graphql.py
@@ -1,8 +1,8 @@
 from __future__ import annotations
 
-import ast
 from collections import defaultdict
 from pathlib import Path
+from typing import TYPE_CHECKING
 
 import typer
 from ariadne_codegen.client_generators.package import PackageGenerator, get_package_generator
@@ -30,6 +30,9 @@
 )
 from .parameters import CONFIG_PARAM
 
+if TYPE_CHECKING:
+    import ast
+
 app = AsyncTyper()
 console = Console()
 
diff --git a/infrahub_sdk/ctl/schema.py b/infrahub_sdk/ctl/schema.py
@@ -2,7 +2,6 @@
 
 import asyncio
 import time
-from pathlib import Path
 from typing import TYPE_CHECKING, Any
 
 import typer
@@ -20,6 +19,8 @@
 from .utils import load_yamlfile_from_disk_and_exit
 
 if TYPE_CHECKING:
+    from pathlib import Path
+
     from .. import InfrahubClient
 
 app = AsyncTyper()
diff --git a/infrahub_sdk/ctl/utils.py b/infrahub_sdk/ctl/utils.py
@@ -3,7 +3,6 @@
 import inspect
 import logging
 import traceback
-from collections.abc import Callable, Coroutine
 from functools import wraps
 from pathlib import Path
 from typing import TYPE_CHECKING, Any, NoReturn, TypeVar
@@ -32,6 +31,8 @@
 from .exceptions import QueryNotFoundError
 
 if TYPE_CHECKING:
+    from collections.abc import Callable, Coroutine
+
     from ..schema.repository import InfrahubRepositoryConfig
     from ..spec.object import ObjectFile
 
diff --git a/infrahub_sdk/exceptions.py b/infrahub_sdk/exceptions.py
@@ -1,7 +1,9 @@
 from __future__ import annotations
 
-from collections.abc import Mapping
-from typing import Any
+from typing import TYPE_CHECKING, Any
+
+if TYPE_CHECKING:
+    from collections.abc import Mapping
 
 
 class Error(Exception):
diff --git a/infrahub_sdk/node/attribute.py b/infrahub_sdk/node/attribute.py
@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 import ipaddress
-from collections.abc import Callable
 from typing import TYPE_CHECKING, Any, get_args
 
 from ..protocols_base import CoreNodeBase
@@ -10,6 +9,8 @@
 from .property import NodeProperty
 
 if TYPE_CHECKING:
+    from collections.abc import Callable
+
     from ..schema import AttributeSchemaAPI
 
 
diff --git a/infrahub_sdk/node/node.py b/infrahub_sdk/node/node.py
@@ -1,6 +1,5 @@
 from __future__ import annotations
 
-from collections.abc import Iterable
 from copy import copy, deepcopy
 from typing import TYPE_CHECKING, Any
 
@@ -28,6 +27,8 @@
 from .relationship import RelationshipManager, RelationshipManagerBase, RelationshipManagerSync
 
 if TYPE_CHECKING:
+    from collections.abc import Iterable
+
     from typing_extensions import Self
 
     from ..client import InfrahubClient, InfrahubClientSync
diff --git a/infrahub_sdk/node/relationship.py b/infrahub_sdk/node/relationship.py
@@ -1,7 +1,6 @@
 from __future__ import annotations
 
 from collections import defaultdict
-from collections.abc import Iterable
 from typing import TYPE_CHECKING, Any
 
 from ..exceptions import (
@@ -14,6 +13,8 @@
 from .related_node import RelatedNode, RelatedNodeSync
 
 if TYPE_CHECKING:
+    from collections.abc import Iterable
+
     from ..client import InfrahubClient, InfrahubClientSync
     from ..schema import RelationshipSchemaAPI
     from .node import InfrahubNode, InfrahubNodeSync
diff --git a/infrahub_sdk/protocols_generator/generator.py b/infrahub_sdk/protocols_generator/generator.py
@@ -1,7 +1,7 @@
 from __future__ import annotations
 
-from collections.abc import Mapping
 from pathlib import Path
+from typing import TYPE_CHECKING
 
 import jinja2
 
@@ -19,6 +19,9 @@
 )
 from .constants import ATTRIBUTE_KIND_MAP, CORE_BASE_CLASS_TO_SYNCIFY, TEMPLATE_FILE_NAME
 
+if TYPE_CHECKING:
+    from collections.abc import Mapping
+
 
 def load_template() -> str:
     path = Path(__file__).parent / TEMPLATE_FILE_NAME
diff --git a/infrahub_sdk/pytest_plugin/loader.py b/infrahub_sdk/pytest_plugin/loader.py
@@ -1,8 +1,7 @@
 from __future__ import annotations
 
 import contextlib
-from collections.abc import Iterable
-from typing import Any
+from typing import TYPE_CHECKING, Any
 
 import pytest
 import yaml
@@ -25,6 +24,9 @@
 )
 from .models import InfrahubTestFileV1, InfrahubTestGroup
 
+if TYPE_CHECKING:
+    from collections.abc import Iterable
+
 MARKER_MAPPING = {
     "Check": pytest.mark.infrahub_check,
     "GraphQLQuery": pytest.mark.infrahub_graphql_query,
diff --git a/infrahub_sdk/query_groups.py b/infrahub_sdk/query_groups.py
@@ -1,13 +1,14 @@
 from __future__ import annotations
 
-from collections.abc import Sequence
 from typing import TYPE_CHECKING, Any
 
 from .constants import InfrahubClientMode
 from .exceptions import NodeNotFoundError
 from .utils import dict_hash
 
 if TYPE_CHECKING:
+    from collections.abc import Sequence
+
     from .client import InfrahubClient, InfrahubClientSync
     from .node import InfrahubNode, InfrahubNodeSync, RelatedNodeBase
     from .schema import MainSchemaTypesAPI
diff --git a/infrahub_sdk/schema/__init__.py b/infrahub_sdk/schema/__init__.py
@@ -4,7 +4,6 @@
 import inspect
 import json
 import warnings
-from collections.abc import MutableMapping
 from enum import Enum
 from time import sleep
 from typing import TYPE_CHECKING, Any, TypeAlias, TypedDict
@@ -42,6 +41,8 @@
 )
 
 if TYPE_CHECKING:
+    from collections.abc import MutableMapping
+
     from ..client import InfrahubClient, InfrahubClientSync, SchemaType, SchemaTypeSync
     from ..node import InfrahubNode, InfrahubNodeSync
 
diff --git a/infrahub_sdk/schema/main.py b/infrahub_sdk/schema/main.py
@@ -1,7 +1,7 @@
 from __future__ import annotations
 
 import warnings
-from collections.abc import MutableMapping
+from collections.abc import MutableMapping  # noqa: TC003 - Required at runtime for Pydantic field validation
 from enum import Enum
 from typing import TYPE_CHECKING, Any
 
diff --git a/infrahub_sdk/task/models.py b/infrahub_sdk/task/models.py
@@ -1,6 +1,6 @@
 from __future__ import annotations
 
-from datetime import datetime
+from datetime import datetime  # noqa: TC003 - Required at runtime for Pydantic field validation
 from enum import Enum
 
 from pydantic import BaseModel, Field
diff --git a/infrahub_sdk/template/__init__.py b/infrahub_sdk/template/__init__.py
@@ -1,9 +1,8 @@
 from __future__ import annotations
 
 import linecache
-from collections.abc import Callable
 from pathlib import Path
-from typing import Any, NoReturn
+from typing import TYPE_CHECKING, Any, NoReturn
 
 import jinja2
 from jinja2 import meta, nodes
@@ -22,6 +21,9 @@
 from .filters import AVAILABLE_FILTERS
 from .models import UndefinedJinja2Error
 
+if TYPE_CHECKING:
+    from collections.abc import Callable
+
 netutils_filters = jinja2_convenience_function()
 
 
diff --git a/infrahub_sdk/topological_sort.py b/infrahub_sdk/topological_sort.py
@@ -1,8 +1,10 @@
 from __future__ import annotations
 
-from collections.abc import Iterable, Mapping, Sequence
 from itertools import chain
-from typing import Any
+from typing import TYPE_CHECKING, Any
+
+if TYPE_CHECKING:
+    from collections.abc import Iterable, Mapping, Sequence
 
 
 class DependencyCycleExistsError(Exception):
diff --git a/infrahub_sdk/transfer/exporter/interface.py b/infrahub_sdk/transfer/exporter/interface.py
@@ -1,7 +1,10 @@
 from __future__ import annotations
 
 from abc import ABC, abstractmethod
-from pathlib import Path
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from pathlib import Path
 
 
 class ExporterInterface(ABC):
diff --git a/infrahub_sdk/transfer/exporter/json.py b/infrahub_sdk/transfer/exporter/json.py
@@ -1,8 +1,6 @@
 from __future__ import annotations
 
-from collections.abc import Generator
 from contextlib import contextmanager
-from pathlib import Path
 from typing import TYPE_CHECKING, Any
 
 import ujson
@@ -15,6 +13,9 @@
 from .interface import ExporterInterface
 
 if TYPE_CHECKING:
+    from collections.abc import Generator
+    from pathlib import Path
+
     from rich.console import Console
 
     from ...client import InfrahubClient
diff --git a/infrahub_sdk/transfer/importer/json.py b/infrahub_sdk/transfer/importer/json.py
@@ -1,9 +1,7 @@
 from __future__ import annotations
 
 from collections import defaultdict
-from collections.abc import Generator, Mapping, Sequence
 from contextlib import contextmanager
-from pathlib import Path
 from typing import TYPE_CHECKING, Any
 
 import pyarrow.json as pa_json
@@ -16,6 +14,9 @@
 from .interface import ImporterInterface
 
 if TYPE_CHECKING:
+    from collections.abc import Generator, Mapping, Sequence
+    from pathlib import Path
+
     from rich.console import Console
 
     from ...batch import InfrahubBatch
diff --git a/infrahub_sdk/transfer/schema_sorter.py b/infrahub_sdk/transfer/schema_sorter.py
@@ -1,12 +1,13 @@
 from __future__ import annotations
 
-from collections.abc import Sequence
 from typing import TYPE_CHECKING
 
 from ..topological_sort import DependencyCycleExistsError, topological_sort
 from .exceptions import SchemaImportError
 
 if TYPE_CHECKING:
+    from collections.abc import Sequence
+
     from ..schema import NodeSchema
 
 
diff --git a/pyproject.toml b/pyproject.toml
@@ -258,7 +258,6 @@ ignore = [
     "S701",    # By default, jinja2 sets `autoescape` to `False`. Consider using `autoescape=True`
     "SIM108",  # Use ternary operator `key_str = f"{value[ALIAS_KEY]}: {key}" if ALIAS_KEY in value and value[ALIAS_KEY] else key` instead of `if`-`else`-block
     "SIM110",  # Use `return any(getattr(item, resource_field) == resource_id for item in getattr(self, RESOURCE_MAP[resource_type]))` instead of `for` loop
-    "TC003",   # Move standard library import `collections.abc.Iterable` into a type-checking block
     "UP031",   # Use format specifiers instead of percent format
 ]
 
diff --git a/tests/integration/test_infrahub_client.py b/tests/integration/test_infrahub_client.py
diff --git a/tests/integration/test_infrahub_client_sync.py b/tests/integration/test_infrahub_client_sync.py
diff --git a/tests/unit/sdk/checks/test_checks.py b/tests/unit/sdk/checks/test_checks.py
diff --git a/tests/unit/sdk/conftest.py b/tests/unit/sdk/conftest.py
