fix: allow for using datetime in list, dict and pydantic model#92
Merged
Conversation
There was a problem hiding this comment.
🚀 Summary
This PR introduces ISO-8601 serialization for datetime objects in prepare_input and switches Pydantic handling to model_dump(mode="json"). The accompanying tests exercise basic types, nested collections, and datetimes. Version bumped to 0.31.4 and CI config remains unchanged.
✅ What Looks Good
| Area | Notes |
|---|---|
| Correctness | Datetime → ISO string conversion works and is unit-tested. |
| Test Coverage | 78 new LOC cover positive & mixed-type cases; tests read well. |
| Style & Readability | Implementation is concise; no lint issues observed. |
| Backwards Compatibility | Existing behaviour for str/int/bool/None unaffected. |
💡 Suggestions / Non-blocking
- Timezone awareness – Consider adding a test for timezone-aware datetimes (
datetime.now(timezone.utc)) to ensure correct offset preservation. - Redundant logic –
DateTimeEncoder.default()duplicates the newisinstance(x, datetime)branch inprepare_input. You could rely on one path to avoid divergence. - Changelog / Docs – Add a note in CHANGELOG or README about datetime support so downstream users discover it easily.
- Microseconds – If API consumers don’t need microsecond precision, consider stripping them to reduce payload noise.
Overall these are polish items and do not block merging.
Reviewed by agentobot[bot] – bringing research-backed, high-impact feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.