✨ Generate and use ApplyConfiguration types for Server-Side Apply (#2515)

* Generate apply configuration types for OLM API types

Use controller-gen's applyconfiguration generator to produce typed
apply configuration structs for Server-Side Apply. This adds generated
types for ClusterCatalog, ClusterExtension, ClusterExtensionRevision,
and all their sub-types in applyconfigurations/.

Changes:
- Add applyconfiguration generator to the Makefile generate target
- Add +kubebuilder:ac:generate=true and +kubebuilder:ac:output:package
  markers to the API package
- Add SchemeGroupVersion alias required by the generated code

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Use ClusterExtensionRevision ApplyConfiguration types in Boxcutter

Migrate Boxcutter from deprecated client.Patch(ctx, rev, client.Apply)
to typed client.Apply(ctx, rev) using the generated
ClusterExtensionRevisionApplyConfiguration types.

- ClusterExtensionRevisionGenerator interface now returns AC types
- GenerateRevision/GenerateRevisionFromHelmRelease build AC objects
  directly via builder pattern instead of API struct literals
- Rename createOrUpdate to apply; uses client.Apply instead of
  deprecated client.Patch with client.Apply option
- Owner references set via metav1ac.OwnerReference() builder instead
  of controllerutil.SetControllerReference
- BoxcutterStorageMigrator.Migrate uses client.Apply; interface
  replaces Create with Apply and adds FieldOwner field
- PhaseSort and helpers operate on AC types natively
- All tests updated to use AC builder pattern and mock Apply

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: joelanford

Makefile

@@ -197,8 +197,10 @@ manifests: update-crds $(MANIFESTS) $(HELM) #EXHELP Generate OLMv1 manifests
 	$(HELM) template olmv1 helm/olmv1 --set "options.openshift.enabled=true" > /dev/null
 
 .PHONY: generate
-generate: $(CONTROLLER_GEN) #EXHELP Generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.
-	@find api cmd hack internal -name "zz_generated.deepcopy.go" -not -path "*/vendor/*" -delete # Need to delete the files for them to be generated properly
+generate: $(CONTROLLER_GEN) #EXHELP Generate code containing DeepCopy, DeepCopyInto, DeepCopyObject, and ApplyConfiguration type implementations.
+	# Need to delete the files for them to be generated properly
+	@find api cmd hack internal -name "zz_generated.deepcopy.go" -not -path "*/vendor/*" -delete && rm -rf applyconfigurations
+	$(CONTROLLER_GEN) --load-build-tags=$(GO_BUILD_TAGS) applyconfiguration:headerFile="hack/boilerplate.go.txt" paths="./api/..."
 	$(CONTROLLER_GEN) --load-build-tags=$(GO_BUILD_TAGS) object:headerFile="hack/boilerplate.go.txt" paths="./..."
 
 .PHONY: verify

api/v1/clustercatalog_types.go

@@ -44,6 +44,8 @@ const (
 	ReasonUserSpecifiedUnavailable = "UserSpecifiedUnavailable"
 )
 
+// +genclient
+// +genclient:nonNamespaced
 //+kubebuilder:object:root=true
 //+kubebuilder:resource:scope=Cluster
 //+kubebuilder:subresource:status

api/v1/clusterextension_types.go

@@ -537,6 +537,8 @@ type ClusterExtensionInstallStatus struct {
 	Bundle BundleMetadata `json:"bundle"`
 }
 
+// +genclient
+// +genclient:nonNamespaced
 // +kubebuilder:object:root=true
 // +kubebuilder:resource:scope=Cluster
 // +kubebuilder:subresource:status

api/v1/clusterextensionrevision_types.go

@@ -252,6 +252,8 @@ type ClusterExtensionRevisionStatus struct {
 	Conditions []metav1.Condition `json:"conditions,omitempty"`
 }
 
+// +genclient
+// +genclient:nonNamespaced
 // +kubebuilder:object:root=true
 // +kubebuilder:resource:scope=Cluster
 // +kubebuilder:subresource:status

api/v1/groupversion_info.go

@@ -17,6 +17,8 @@ limitations under the License.
 // Package v1 contains API Schema definitions for the olm v1 API group
 // +kubebuilder:object:generate=true
 // +groupName=olm.operatorframework.io
+// +kubebuilder:ac:generate=true
+// +kubebuilder:ac:output:package=../../applyconfigurations
 package v1
 
 import (
@@ -28,6 +30,10 @@ var (
 	// GroupVersion is group version used to register these objects
 	GroupVersion = schema.GroupVersion{Group: "olm.operatorframework.io", Version: "v1"}
 
+	// SchemeGroupVersion is an alias for GroupVersion, required by the
+	// generated apply configuration code.
+	SchemeGroupVersion = GroupVersion
+
 	// SchemeBuilder is used to add go types to the GroupVersionKind scheme
 	SchemeBuilder = &scheme.Builder{GroupVersion: GroupVersion}