adguardhome: adguardhome user/group not created

[russelltg]

Package Name

adguardhome

Maintainer

@GeorgeSapkin

OpenWrt Version

25.12.0-rc1

OpenWrt Target/Subtarget

mediatek/filogic

Steps to Reproduce

1. Install adguard home with apk
2. Put config in /etc/adguardhome/adguardhome.yaml
3. have

config adguardhome config
	# Where to store persistent data by AdGuard Home
	option workdir /var/adguardhome
	option config /etc/adguardhome/adguardhome.yaml

in /etc/config/adguardhome
4. run service adguardhome restart

Actual Behaviour

Get

chown: unknown user/group adguardhome:adguardhome
chown: unknown user/group adguardhome:adguardhome

on commandline.

Confirmation Checklist

• The package is maintained in this repository.
• I understand that issues related to the base OpenWrt repository or LuCI repository will be closed.
• I am reporting an issue for OpenWrt, not an unsupported fork.

[GeorgeSapkin]

I just did clean install on a clean 25.12-rc1 VM and I get:

root@OpenWrt:~# cat /etc/group
root:x:0:
daemon:x:1:
adm:x:4:
mail:x:8:
dialout:x:20:
audio:x:29:
www-data:x:33:
ftp:x:55:
users:x:100:
network:x:101:
nogroup:x:65534:
ntp:x:123:ntp
dnsmasq:x:453:dnsmasq
logd:x:514:logd
ubus:x:81:ubus

root@OpenWrt:~# cat /etc/group 
root:x:0:
daemon:x:1:
adm:x:4:
mail:x:8:
dialout:x:20:
audio:x:29:
www-data:x:33:
ftp:x:55:
users:x:100:
network:x:101:
nogroup:x:65534:
ntp:x:123:ntp
dnsmasq:x:453:dnsmasq
logd:x:514:logd
ubus:x:81:ubus

root@OpenWrt:~# apk update
 [https://downloads.openwrt.org/releases/25.12.0-rc1/targets/x86/64/packages/packages.adb]
 [https://downloads.openwrt.org/releases/25.12.0-rc1/packages/x86_64/base/packages.adb]
 [https://downloads.openwrt.org/releases/25.12.0-rc1/targets/x86/64/kmods/6.12.62-1-780c76c9e68ba0964ba865d615ce42f0/packages.adb]
 [https://downloads.openwrt.org/releases/25.12.0-rc1/packages/x86_64/luci/packages.adb]
 [https://downloads.openwrt.org/releases/25.12.0-rc1/packages/x86_64/packages/packages.adb]
 [https://downloads.openwrt.org/releases/25.12.0-rc1/packages/x86_64/routing/packages.adb]
 [https://downloads.openwrt.org/releases/25.12.0-rc1/packages/x86_64/telephony/packages.adb]
 [https://downloads.openwrt.org/releases/25.12.0-rc1/packages/x86_64/video/packages.adb]
OK: 10777 distinct packages available

root@OpenWrt:~# apk add adguardhome
(1/1) Installing adguardhome (0.107.71-r1)
  Executing adguardhome-0.107.71-r1.post-install
  * AdGuard Home config is in its default path '/etc/adguardhome/adguardhome.yaml'
OK: 51.4 MiB in 181 packages
root@OpenWrt:~# cat /etc/config/adguardhome 
config adguardhome 'config'
	# All paths must be readable by the configured user
	option config_file '/etc/adguardhome/adguardhome.yaml'
	# Where to store persistent data by AdGuard Home
	option work_dir '/var/lib/adguardhome'
	option user 'adguardhome'
	option group 'adguardhome'
	option verbose '0'
	# Files and directories that AdGuard Home has read-only access to
	# list jail_mount '/etc/ssl/adguardhome.crt'
	# list jail_mount '/etc/ssl/adguardhome.key'

root@OpenWrt:~# cat /etc/passwd 
root:x:0:0:root:/root:/bin/ash
daemon:*:1:1:daemon:/var:/bin/false
ftp:*:55:55:ftp:/home/ftp:/bin/false
network:*:101:101:network:/var:/bin/false
nobody:*:65534:65534:nobody:/var:/bin/false
ntp:x:123:123:ntp:/var/run/ntp:/bin/false
dnsmasq:x:453:453:dnsmasq:/var/run/dnsmasq:/bin/false
logd:x:514:514:logd:/var/run/logd:/bin/false
ubus:x:81:81:ubus:/var/run/ubus:/bin/false
adguardhome:x:853:853:adguardhome:/var/run/adguardhome:/bin/false

root@OpenWrt:~# cat /etc/group 
root:x:0:
daemon:x:1:
adm:x:4:
mail:x:8:
dialout:x:20:
audio:x:29:
www-data:x:33:
ftp:x:55:
users:x:100:
network:x:101:
nogroup:x:65534:
ntp:x:123:ntp
dnsmasq:x:453:dnsmasq
logd:x:514:logd
ubus:x:81:ubus
adguardhome:x:853:adguardhome

Default user/group combo was correctly created on install. And I can connect to the web UI.

Can you share more details?

[russelltg]

Hmm funky, I can't repro in a VM either.

My real machine was installed with a sdcard image created from the firmware selector, and I put adguardhome direclty in the

Customize installed packages and/or first boot script

Section.

Doing a apk del adguardhome followed by apk add adguardhome seemed to fix the issue on my router

[GeorgeSapkin]

Interesting. The user is created by the post install/upgrade script. Could it be that these are not being run by that tool? 🤔

[GeorgeSapkin]

Maybe open an issue there in asu and cc me?

[efahl]

This looks like something isn't running properly in the imagebuilder, which should execute the install scripts on the fake root and create the group and user in what will become the device rootfs. Hmm, maybe a permissions issue?

An easy way to test is to use the docker container for the target in question. Maybe not working because we run as user buildbot???

$ podman run -it ghcr.io/openwrt/imagebuilder:mediatek-filogic-main
buildbot@12a891471ee7:~$ whoami
buildbot
buildbot@12a891471ee7:~$ . setup
... wait a while ...

$ make image PACKAGES=adguardhome
...

< poke around and see what happened >

I'll experiment and see what I can see.

[efahl]

Notes thus far, made in an imagebuilder that includes 21288. It works there.

Makefile contains https://github.com/openwrt/packages/blob/master/net/adguardhome/Makefile#L46

USERID:=adguardhome=853:adguardhome=853

package-pack.mk turns this into

include/package-pack.mk:        if [ -n "$(USERID)" ]; then echo $(USERID) > $$(IDIR_$(1))/lib/apk/packages/$(1)$$(ABIV_$(1)).rusers; fi;

On install we see a file in fakeroot (fakeroot = build_dir/target-x86_64_musl/root-x86/):

$ cat fakeroot/lib/apk/packages/adguardhome.rusers
adguardhome=853:adguardhome=853

And in the installed db we see this.

$ grep adguardhome.rusers fakeroot/lib/apk/db/installed
R:adguardhome.rusers

Then this happens, but when? At install on the host inside imagebuilder?
https://github.com/openwrt/openwrt/blob/main/package/base-files/files/lib/functions.sh#L243

Must be, because the user/group already exists in passwd and shadow.

Could this have been failing pre-21288?

Here's the expected and found result, which seems correct, right?

$ grep -r adguardhome build_dir/target-x86_64_musl/root-x86/etc/
...
build_dir/target-x86_64_musl/root-x86/etc/passwd:adguardhome:x:853:853:adguardhome:/var/run/adguardhome:/bin/false
build_dir/target-x86_64_musl/root-x86/etc/shadow:adguardhome:x:0:0:99999:7:::
build_dir/target-x86_64_musl/root-x86/etc/group:adguardhome:x:853:adguardhome

[GeorgeSapkin]

Closing, since it seems to be working as expected now.