Skip to content

Dialog improvements #387

@berezh

Description

@berezh

Currently, it opens/closes with state flag within a component.
Disadvantages:

  • need to create additional flag in redux store to handle case the form successfully submitted, subscribe it and if it true - close the dialog. This hack makes app complicated and increases possibility to get a but.
  • dialog can be opened/closed only from specific component by subscribing state flag

To resolve above need to move opeding/closing to redux action.
Example here - a0a1bae#diff-731b906bcd8593e0a5402f1657db9a50bc9066ce8bbd3b37c7760071098e6fb8R12

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions