Skip to content

Commit 961ef31

Browse files
committed
Fix getting server id for listing instances
Just use 'server_id' from the instance response instead. Story: 2008464 Task: 41496 Change-Id: Ib84dbd5fbd752ab7c7607ccb874663b01bfb7388
1 parent 77023b3 commit 961ef31

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

troveclient/osc/v1/database_instances.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ def get_instances_info(instances):
5656
if 'addresses' not in instance_info:
5757
instance_info['addresses'] = ''
5858

59-
if 'server' in instance_info:
60-
instance_info['server_id'] = instance_info['server'].get('id')
61-
6259
if 'operating_status' not in instance_info:
6360
# In case newer version python-troveclient is talking to older
6461
# version trove.

troveclient/tests/osc/v1/test_database_instances.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ def test_instance_list_all_projects(self):
109109
},
110110
"tenant_id": tenant_id,
111111
"access": {"is_public": False, "allowed_cidrs": []},
112+
"server_id": server_id,
112113
'server': {
113114
'id': server_id
114115
}
@@ -157,6 +158,7 @@ def test_instance_list_for_project(self):
157158
},
158159
"tenant_id": tenant_id,
159160
"access": {"is_public": False, "allowed_cidrs": []},
161+
"server_id": server_id,
160162
'server': {
161163
'id': server_id
162164
}

0 commit comments

Comments
 (0)