Skip to content

Commit ff96fea

Browse files
author
Thrivikram Mudunuri
committed
Switch server suspend and server resume to SDK
Switch the server suspend and server resume commands from novaclient to SDK. Use the SDK versions of test fakes to support fake Server resources. Change-Id: Idd0b4f13fab0f238e42844a7d759538bbda24f68
1 parent b515fe6 commit ff96fea

3 files changed

Lines changed: 19 additions & 14 deletions

File tree

openstackclient/compute/v2/server.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4081,13 +4081,13 @@ def get_parser(self, prog_name):
40814081
return parser
40824082

40834083
def take_action(self, parsed_args):
4084-
4085-
compute_client = self.app.client_manager.compute
4084+
compute_client = self.app.client_manager.sdk_connection.compute
40864085
for server in parsed_args.server:
4087-
utils.find_resource(
4088-
compute_client.servers,
4086+
server_id = compute_client.find_server(
40894087
server,
4090-
).resume()
4088+
ignore_missing=False,
4089+
).id
4090+
compute_client.resume_server(server_id)
40914091

40924092

40934093
class SetServer(command.Command):
@@ -4652,13 +4652,13 @@ def get_parser(self, prog_name):
46524652
return parser
46534653

46544654
def take_action(self, parsed_args):
4655-
4656-
compute_client = self.app.client_manager.compute
4655+
compute_client = self.app.client_manager.sdk_connection.compute
46574656
for server in parsed_args.server:
4658-
utils.find_resource(
4659-
compute_client.servers,
4657+
server_id = compute_client.find_server(
46604658
server,
4661-
).suspend()
4659+
ignore_missing=False,
4660+
).id
4661+
compute_client.suspend_server(server_id)
46624662

46634663

46644664
class UnlockServer(command.Command):

openstackclient/tests/unit/compute/v2/test_server.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7617,10 +7617,10 @@ def setUp(self):
76177617
}
76187618

76197619
def test_server_resume_one_server(self):
7620-
self.run_method_with_servers('resume', 1)
7620+
self.run_method_with_sdk_servers('resume_server', 1)
76217621

76227622
def test_server_resume_multi_servers(self):
7623-
self.run_method_with_servers('resume', 3)
7623+
self.run_method_with_sdk_servers('resume_server', 3)
76247624

76257625

76267626
class TestServerSet(TestServer):
@@ -8284,10 +8284,10 @@ def setUp(self):
82848284
}
82858285

82868286
def test_server_suspend_one_server(self):
8287-
self.run_method_with_servers('suspend', 1)
8287+
self.run_method_with_sdk_servers('suspend_server', 1)
82888288

82898289
def test_server_suspend_multi_servers(self):
8290-
self.run_method_with_servers('suspend', 3)
8290+
self.run_method_with_sdk_servers('suspend_server', 3)
82918291

82928292

82938293
class TestServerUnlock(TestServer):
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
features:
3+
- |
4+
Migrate ``server suspend`` and ``server resume`` commands from novaclient
5+
to sdk.

0 commit comments

Comments
 (0)