Skip to content

Commit f8e8ace

Browse files
author
Huanxuan Ao
committed
SDK refactor: Set "is_admin_state_up" for network agent
OpenStackSDK is >=0.9.13 now in requirement, so we can update "is_admin_state_up" as well for the SDK refactor Change-Id: I02de0ebc752ce602032bbe9d73256ed376993e78
1 parent 1e3dc48 commit f8e8ace

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

openstackclient/network/v2/network_agent.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,11 +186,11 @@ def take_action(self, parsed_args):
186186
attrs = {}
187187
if parsed_args.description is not None:
188188
attrs['description'] = str(parsed_args.description)
189-
# TODO(huanxuan): Also update by the new attribute name
190-
# "is_admin_state_up" after sdk 0.9.12
191189
if parsed_args.enable:
190+
attrs['is_admin_state_up'] = True
192191
attrs['admin_state_up'] = True
193192
if parsed_args.disable:
193+
attrs['is_admin_state_up'] = False
194194
attrs['admin_state_up'] = False
195195
client.update_agent(obj, **attrs)
196196

openstackclient/tests/unit/network/v2/test_network_agent.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,6 @@ def test_network_agents_list_host(self):
195195
self.assertEqual(self.data, list(data))
196196

197197

198-
# TODO(huanxuan): Also update by the new attribute name
199-
# "is_admin_state_up" after sdk 0.9.12
200198
class TestSetNetworkAgent(TestNetworkAgent):
201199

202200
_network_agent = (
@@ -245,6 +243,7 @@ def test_set_all(self):
245243
attrs = {
246244
'description': 'new_description',
247245
'admin_state_up': True,
246+
'is_admin_state_up': True,
248247
}
249248
self.network.update_agent.assert_called_once_with(
250249
self._network_agent, **attrs)
@@ -266,6 +265,7 @@ def test_set_with_disable(self):
266265

267266
attrs = {
268267
'admin_state_up': False,
268+
'is_admin_state_up': False,
269269
}
270270
self.network.update_agent.assert_called_once_with(
271271
self._network_agent, **attrs)

0 commit comments

Comments
 (0)