Skip to content

Commit eb06a24

Browse files
Modify the help message for 'registered limit set'
Regsitered limit set CLI takes --service, --region and --resource-name as param which can be updated along with --default limit for existing registered limit. Default limit can be updated with same value and CLI return the success. But --service, --region and --resource- name cannot be same as existing one. CLI return 409 for this case. Which is valid behaviour because more than one limit with same service and same resource cannot exist. But help message of --service, --region and --resource-name are not much clear to tell that they cannot be passed with same value. This patch clarifies the help message for resigtered limit set CLI. Reference Scenario: * openstack registered limit set --default-limit 91 64c2e97fbe904b888544ffdcab21989b limit updated sucessfully Updating limit with exsiting service and resource-name: * openstack registered limit set --default-limit 92 --resource-name snapshot 64c2e97fbe904b888544ffdcab21989b Conflict occurred attempting to store registered_limit - Duplicate entry. (HTTP 409) *openstack registered limit set --default-limit 93 --service compute 64c2e97fbe904b888544ffdcab21989b Conflict occurred attempting to store registered_limit - Duplicate entry. (HTTP 409) *openstack registered limit set --default-limit 91 --resource-name snapshot --service glance 64c2e97fbe904b888544ffdcab21989b Conflict occurred attempting to store registered_limit - Duplicate entry. (HTTP 409) Change-Id: I9e78a6250567cd981adde96946818bb016760a49
1 parent e3dc30f commit eb06a24

1 file changed

Lines changed: 13 additions & 4 deletions

File tree

openstackclient/identity/v3/registered_limit.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -186,12 +186,18 @@ def get_parser(self, prog_name):
186186
parser.add_argument(
187187
'--service',
188188
metavar='<service>',
189-
help=_('Service responsible for the resource to limit'),
189+
help=_('Service to be updated responsible for the resource to '
190+
'limit. Either --service, --resource-name or --region must '
191+
'be different than existing value otherwise it will be '
192+
'duplicate entry')
190193
)
191194
parser.add_argument(
192195
'--resource-name',
193196
metavar='<resource-name>',
194-
help=_('The name of the resource to limit'),
197+
help=_('Resource to be updated responsible for the resource to '
198+
'limit. Either --service, --resource-name or --region must '
199+
'be different than existing value otherwise it will be '
200+
'duplicate entry'),
195201
)
196202
parser.add_argument(
197203
'--default-limit',
@@ -202,12 +208,15 @@ def get_parser(self, prog_name):
202208
parser.add_argument(
203209
'--description',
204210
metavar='<description>',
205-
help=_('Description of the registered limit'),
211+
help=_('Description to update of the registered limit'),
206212
)
207213
parser.add_argument(
208214
'--region',
209215
metavar='<region>',
210-
help=_('Region for the registered limit to affect.'),
216+
help=_('Region for the registered limit to affect. Either '
217+
'--service, --resource-name or --region must be '
218+
'different than existing value otherwise it will be '
219+
'duplicate entry'),
211220
)
212221
return parser
213222

0 commit comments

Comments
 (0)