Skip to content

Commit db29e28

Browse files
committed
Switch to using osc_lib.utils.tags
This patch updates the network modules to use the new osc_lib.utils.tags module and removes the in tree _tag.py version. A previous patch[1] moves the _tag.py code to osc-lib to allow other projects to leverage the code. [1] https://review.opendev.org/662859 Change-Id: Id0c34029e327de50c5fd2732bae5fbf45bbd16ee
1 parent 4a2aa4a commit db29e28

10 files changed

Lines changed: 9 additions & 153 deletions

File tree

lower-constraints.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ openstacksdk==0.17.0
5454
os-client-config==1.28.0
5555
os-service-types==1.2.0
5656
os-testr==1.0.0
57-
osc-lib==1.14.0
57+
osc-lib==2.0.0
5858
osc-placement==1.7.0
5959
oslo.concurrency==3.26.0
6060
oslo.config==5.2.0

openstackclient/network/v2/_tag.py

Lines changed: 0 additions & 144 deletions
This file was deleted.

openstackclient/network/v2/floating_ip.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616
from osc_lib.cli import format_columns
1717
from osc_lib.command import command
1818
from osc_lib import utils
19+
from osc_lib.utils import tags as _tag
1920

2021
from openstackclient.i18n import _
2122
from openstackclient.identity import common as identity_common
2223
from openstackclient.network import common
2324
from openstackclient.network import sdk_utils
24-
from openstackclient.network.v2 import _tag
2525

2626

2727
_formatters = {

openstackclient/network/v2/network.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717
from osc_lib.cli import format_columns
1818
from osc_lib.command import command
1919
from osc_lib import utils
20+
from osc_lib.utils import tags as _tag
2021

2122
from openstackclient.i18n import _
2223
from openstackclient.identity import common as identity_common
2324
from openstackclient.network import common
2425
from openstackclient.network import sdk_utils
25-
from openstackclient.network.v2 import _tag
2626

2727

2828
class AdminStateColumn(cliff_columns.FormattableColumn):

openstackclient/network/v2/port.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,12 +24,12 @@
2424
from osc_lib.command import command
2525
from osc_lib import exceptions
2626
from osc_lib import utils
27+
from osc_lib.utils import tags as _tag
2728

2829
from openstackclient.i18n import _
2930
from openstackclient.identity import common as identity_common
3031
from openstackclient.network import common
3132
from openstackclient.network import sdk_utils
32-
from openstackclient.network.v2 import _tag
3333

3434

3535
LOG = logging.getLogger(__name__)

openstackclient/network/v2/router.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,11 @@
2323
from osc_lib.command import command
2424
from osc_lib import exceptions
2525
from osc_lib import utils
26+
from osc_lib.utils import tags as _tag
2627

2728
from openstackclient.i18n import _
2829
from openstackclient.identity import common as identity_common
2930
from openstackclient.network import sdk_utils
30-
from openstackclient.network.v2 import _tag
3131

3232

3333
LOG = logging.getLogger(__name__)

openstackclient/network/v2/security_group.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,13 @@
1919
from osc_lib.cli import format_columns
2020
from osc_lib.command import command
2121
from osc_lib import utils
22+
from osc_lib.utils import tags as _tag
2223

2324
from openstackclient.i18n import _
2425
from openstackclient.identity import common as identity_common
2526
from openstackclient.network import common
2627
from openstackclient.network import sdk_utils
2728
from openstackclient.network import utils as network_utils
28-
from openstackclient.network.v2 import _tag
2929

3030

3131
def _format_network_security_group_rules(sg_rules):

openstackclient/network/v2/subnet.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@
2222
from osc_lib.command import command
2323
from osc_lib import exceptions
2424
from osc_lib import utils
25+
from osc_lib.utils import tags as _tag
2526

2627
from openstackclient.i18n import _
2728
from openstackclient.identity import common as identity_common
2829
from openstackclient.network import sdk_utils
29-
from openstackclient.network.v2 import _tag
3030

3131

3232
LOG = logging.getLogger(__name__)

openstackclient/network/v2/subnet_pool.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@
2020
from osc_lib.command import command
2121
from osc_lib import exceptions
2222
from osc_lib import utils
23+
from osc_lib.utils import tags as _tag
2324

2425
from openstackclient.i18n import _
2526
from openstackclient.identity import common as identity_common
2627
from openstackclient.network import sdk_utils
27-
from openstackclient.network.v2 import _tag
2828

2929

3030
LOG = logging.getLogger(__name__)

requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ Babel!=2.4.0,>=2.3.4 # BSD
88
cliff!=2.9.0,>=2.8.0 # Apache-2.0
99
keystoneauth1>=3.6.2 # Apache-2.0
1010
openstacksdk>=0.17.0 # Apache-2.0
11-
osc-lib>=1.14.0 # Apache-2.0
11+
osc-lib>=2.0.0 # Apache-2.0
1212
oslo.i18n>=3.15.3 # Apache-2.0
1313
oslo.utils>=3.33.0 # Apache-2.0
1414
python-glanceclient>=2.8.0 # Apache-2.0

0 commit comments

Comments
 (0)