Skip to content

Commit d0d4077

Browse files
committed
tests: Remove prints
Change-Id: I35adac1199769fd73978b6457044191d02bb5bd4 Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
1 parent 1678f87 commit d0d4077

3 files changed

Lines changed: 1 addition & 11 deletions

File tree

openstackclient/tests/unit/identity/v3/test_trust.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,6 @@ def test_trust_list_trustee(self):
294294
# containing the data to be listed.
295295
columns, data = self.cmd.take_action(parsed_args)
296296

297-
print(self.trusts_mock.list.call_args_list)
298297
self.trusts_mock.list.assert_any_call(
299298
trustee_user=self.users_mock.get(),
300299
trustor_user=None,
@@ -335,7 +334,6 @@ def test_trust_list_trustor(self):
335334
# containing the data to be listed.
336335
columns, data = self.cmd.take_action(parsed_args)
337336

338-
print(self.trusts_mock.list.call_args_list)
339337
self.trusts_mock.list.assert_any_call(
340338
trustor_user=self.users_mock.get(),
341339
trustee_user=None,

openstackclient/tests/unit/integ/cli/test_shell.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,6 @@ def vendor_mock_return():
502502
)
503503

504504
# +env, -cli, +occ
505-
print("auth_req: %s" % auth_req['auth'])
506505
self.assertEqual(
507506
test_shell.DEFAULT_USERNAME,
508507
auth_req['auth']['identity']['password']['user']['name'],
@@ -559,7 +558,6 @@ def vendor_mock_return():
559558
)
560559

561560
# +env, +cli, +occ
562-
print("auth_req: %s" % auth_req['auth'])
563561
self.assertEqual(
564562
'zarquon',
565563
auth_req['auth']['identity']['password']['user']['name'],

openstackclient/tests/unit/test_shell.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -141,10 +141,6 @@ class TestShell(osc_lib_test_utils.TestShell):
141141
# Full name of the OpenStackShell class to test (cliff.app.App subclass)
142142
shell_class_name = "openstackclient.shell.OpenStackShell"
143143

144-
# TODO(dtroyer): remove this once the shell_class_patch patch is released
145-
# in osc-lib
146-
app_patch = shell_class_name
147-
148144
def setUp(self):
149145
super(TestShell, self).setUp()
150146
# TODO(dtroyer): remove this once the shell_class_patch patch is
@@ -162,7 +158,6 @@ def _assert_admin_token_auth(self, cmd_options, default_args):
162158
)
163159
_cmd = cmd_options + " list role"
164160
osc_lib_test_utils.fake_execute(_shell, _cmd)
165-
print("_shell: %s" % _shell)
166161

167162
self.app.assert_called_with(["list", "role"])
168163
self.assertEqual(
@@ -178,15 +173,14 @@ def _assert_admin_token_auth(self, cmd_options, default_args):
178173

179174
def _assert_token_auth(self, cmd_options, default_args):
180175
with mock.patch(
181-
self.app_patch + ".initialize_app",
176+
self.shell_class_name + ".initialize_app",
182177
self.app,
183178
):
184179
_shell = osc_lib_test_utils.make_shell(
185180
shell_class=self.shell_class,
186181
)
187182
_cmd = cmd_options + " list role"
188183
osc_lib_test_utils.fake_execute(_shell, _cmd)
189-
print("_shell: %s" % _shell)
190184

191185
self.app.assert_called_with(["list", "role"])
192186
self.assertEqual(

0 commit comments

Comments
 (0)