Skip to content

Commit cf078fd

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Use Server.to_dict() rather than Server._info"
2 parents a7973d9 + 56b3467 commit cf078fd

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

openstackclient/compute/v2/server.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,13 +124,14 @@ def _prep_server_detail(compute_client, image_client, server):
124124
"""Prepare the detailed server dict for printing
125125
126126
:param compute_client: a compute client instance
127+
:param image_client: an image client instance
127128
:param server: a Server resource
128129
:rtype: a dict of server details
129130
"""
130-
info = server._info.copy()
131+
info = server.to_dict()
131132

132133
server = utils.find_resource(compute_client.servers, info['id'])
133-
info.update(server._info)
134+
info.update(server.to_dict())
134135

135136
# Convert the image blob to a name
136137
image_info = info.get('image', {})
@@ -178,7 +179,7 @@ def _prep_server_detail(compute_client, image_client, server):
178179
if 'tenant_id' in info:
179180
info['project_id'] = info.pop('tenant_id')
180181

181-
# Map power state num to meanful string
182+
# Map power state num to meaningful string
182183
if 'OS-EXT-STS:power_state' in info:
183184
info['OS-EXT-STS:power_state'] = _format_servers_list_power_state(
184185
info['OS-EXT-STS:power_state'])
@@ -1521,7 +1522,8 @@ def _show_progress(progress):
15211522
compute_client.servers, parsed_args.server)
15221523

15231524
# If parsed_args.image is not set, default to the currently used one.
1524-
image_id = parsed_args.image or server._info.get('image', {}).get('id')
1525+
image_id = parsed_args.image or server.to_dict().get(
1526+
'image', {}).get('id')
15251527
image = utils.find_resource(image_client.images, image_id)
15261528

15271529
server = server.rebuild(image, parsed_args.password)

0 commit comments

Comments
 (0)