Skip to content

Commit c901620

Browse files
author
Dean Troyer
committed
Attempt to de-race qos policy
We're getting about 1-in-6 failures on qos policy delete now, with the message that the policy is in use by a network. It shouldn't be, this is possibly due to the small window where the policy is set as the default. Let's remove that and shore up the test using --share instead. Change-Id: I8d669bd3c5c88dadd2927aee89e5ef72cf4001c4
1 parent 09faba2 commit c901620

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

openstackclient/tests/functional/network/v2/test_network_qos_policy.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ def test_qos_policy_set(self):
6666
self.openstack(
6767
'network qos policy set ' +
6868
'--share ' +
69-
'--default ' +
7069
policy_name
7170
)
7271

@@ -75,11 +74,16 @@ def test_qos_policy_set(self):
7574
policy_name
7675
))
7776
self.assertTrue(json_output['shared'])
78-
self.assertTrue(json_output['is_default'])
7977

80-
self.openstack('network qos policy set --no-default ' + policy_name)
78+
self.openstack(
79+
'network qos policy set ' +
80+
'--no-share ' +
81+
'--no-default ' +
82+
policy_name
83+
)
8184
json_output = json.loads(self.openstack(
8285
'network qos policy show -f json ' +
8386
policy_name
8487
))
88+
self.assertFalse(json_output['shared'])
8589
self.assertFalse(json_output['is_default'])

0 commit comments

Comments
 (0)