trivial: Prepare for pyupgrade pre-commit hook

This change is entirely automated save for the update of some mocks from
'io.open' to '__builtins__.open').

We are keeping this change separate from addition of the actual hook so
that we can ignore the commit later.

Change-Id: I0a9d8736632084473b57b57b693322447d7be519
Signed-off-by: Stephen Finucane <stephenfin@redhat.com>

Author: stephenfin

doc/source/conf.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 #
 # OpenStack Command Line Client documentation build configuration file, created
 # by sphinx-quickstart on Wed May 16 12:05:58 2012.

doc/source/contributor/command-errors.rst

@@ -45,7 +45,7 @@ raised that includes the name of the file that was attempted to be opened.
             public_key = parsed_args.public_key
             if public_key:
                 try:
-                    with io.open(
+                    with open(
                         os.path.expanduser(parsed_args.public_key),
                         "rb"
                     ) as p:

openstackclient/api/api.py

@@ -21,7 +21,7 @@
 from openstackclient.i18n import _
 
 
-class KeystoneSession(object):
+class KeystoneSession:
     """Wrapper for the Keystone Session
 
     Restore some requests.session.Session compatibility;
@@ -40,7 +40,7 @@ def __init__(self, session=None, endpoint=None, **kwargs):
             requests on this API.
         """
 
-        super(KeystoneSession, self).__init__()
+        super().__init__()
 
         # a requests.Session-style interface
         self.session = session
@@ -95,7 +95,7 @@ def __init__(
             requests on this API.
         """
 
-        super(BaseAPI, self).__init__(session=session, endpoint=endpoint)
+        super().__init__(session=session, endpoint=endpoint)
 
         self.service_type = service_type
 
@@ -303,7 +303,7 @@ def find(
         """
 
         try:
-            ret = self._request('GET', "/%s/%s" % (path, value)).json()
+            ret = self._request('GET', f"/{path}/{value}").json()
         except ks_exceptions.NotFound:
             kwargs = {attr: value}
             try:

openstackclient/api/compute_v2.py

@@ -30,7 +30,7 @@ class APIv2(api.BaseAPI):
     """Compute v2 API"""
 
     def __init__(self, **kwargs):
-        super(APIv2, self).__init__(**kwargs)
+        super().__init__(**kwargs)
 
     # Overrides
 
@@ -76,7 +76,7 @@ def find(
         """
 
         try:
-            ret = self._request('GET', "/%s/%s" % (path, value)).json()
+            ret = self._request('GET', f"/{path}/{value}").json()
             if isinstance(ret, dict):
                 # strip off the enclosing dict
                 key = list(ret.keys())[0]
@@ -136,7 +136,7 @@ def floating_ip_add(
 
         return self._request(
             "POST",
-            "/%s/%s/action" % (url, server['id']),
+            "/{}/{}/action".format(url, server['id']),
             json={'addFloatingIp': body},
         )
 
@@ -180,7 +180,7 @@ def floating_ip_delete(
         url = "/os-floating-ips"
 
         if floating_ip_id is not None:
-            return self.delete('/%s/%s' % (url, floating_ip_id))
+            return self.delete(f'/{url}/{floating_ip_id}')
 
         return None
 
@@ -248,7 +248,7 @@ def floating_ip_remove(
 
         return self._request(
             "POST",
-            "/%s/%s/action" % (url, server['id']),
+            "/{}/{}/action".format(url, server['id']),
             json={'removeFloatingIp': body},
         )
 
@@ -316,7 +316,7 @@ def host_set(
         else:
             return self._request(
                 "PUT",
-                "/%s/%s" % (url, host),
+                f"/{url}/{host}",
                 json=params,
             ).json()
 
@@ -398,7 +398,7 @@ def network_delete(
             value=network,
         )['id']
         if network is not None:
-            return self.delete('/%s/%s' % (url, network))
+            return self.delete(f'/{url}/{network}')
 
         return None
 
@@ -487,7 +487,7 @@ def security_group_delete(
             value=security_group,
         )['id']
         if security_group is not None:
-            return self.delete('/%s/%s' % (url, security_group))
+            return self.delete(f'/{url}/{security_group}')
 
         return None
 
@@ -535,7 +535,7 @@ def security_group_list(
 
         params = {}
         if search_opts is not None:
-            params = dict((k, v) for (k, v) in search_opts.items() if v)
+            params = {k: v for (k, v) in search_opts.items() if v}
         if limit:
             params['limit'] = limit
         if marker:
@@ -549,7 +549,7 @@ def security_group_set(
         security_group=None,
         # name=None,
         # description=None,
-        **params
+        **params,
     ):
         """Update a security group
 
@@ -579,7 +579,7 @@ def security_group_set(
                     security_group[k] = v
             return self._request(
                 "PUT",
-                "/%s/%s" % (url, security_group['id']),
+                "/{}/{}".format(url, security_group['id']),
                 json={'security_group': security_group},
             ).json()['security_group']
         return None
@@ -648,6 +648,6 @@ def security_group_rule_delete(
 
         url = "/os-security-group-rules"
         if security_group_rule_id is not None:
-            return self.delete('/%s/%s' % (url, security_group_rule_id))
+            return self.delete(f'/{url}/{security_group_rule_id}')
 
         return None

openstackclient/api/image_v1.py

@@ -22,7 +22,7 @@ class APIv1(api.BaseAPI):
     _endpoint_suffix = '/v1'
 
     def __init__(self, endpoint=None, **kwargs):
-        super(APIv1, self).__init__(endpoint=endpoint, **kwargs)
+        super().__init__(endpoint=endpoint, **kwargs)
 
         self.endpoint = self.endpoint.rstrip('/')
         self._munge_url()

openstackclient/api/object_store_v1.py

@@ -13,7 +13,6 @@
 
 """Object Store v1 API Library"""
 
-import io
 import logging
 import os
 import sys
@@ -33,7 +32,7 @@ class APIv1(api.BaseAPI):
     """Object Store v1 API"""
 
     def __init__(self, **kwargs):
-        super(APIv1, self).__init__(**kwargs)
+        super().__init__(**kwargs)
 
     def container_create(
         self, container=None, public=False, storage_policy=None
@@ -257,11 +256,11 @@ def object_create(
         # object's name in the container.
         object_name_str = name if name else object
 
-        full_url = "%s/%s" % (
+        full_url = "{}/{}".format(
             urllib.parse.quote(container),
             urllib.parse.quote(object_name_str),
         )
-        with io.open(object, 'rb') as f:
+        with open(object, 'rb') as f:
             response = self.create(
                 full_url,
                 method='PUT',

openstackclient/common/availability_zone.py

@@ -47,7 +47,7 @@ def _xform_compute_availability_zone(az, include_extra):
             for svc, state in services.items():
                 info = copy.deepcopy(host_info)
                 info['service_name'] = svc
-                info['service_status'] = '%s %s %s' % (
+                info['service_status'] = '{} {} {}'.format(
                     'enabled' if state['active'] else 'disabled',
                     ':-)' if state['available'] else 'XXX',
                     state['updated_at'],

openstackclient/common/clientmanager.py

@@ -51,7 +51,7 @@ def __init__(
         api_version=None,
         pw_func=None,
     ):
-        super(ClientManager, self).__init__(
+        super().__init__(
             cli_options=cli_options,
             api_version=api_version,
             pw_func=pw_func,
@@ -94,7 +94,7 @@ def setup_auth(self):
             except TypeError as e:
                 self._fallback_load_auth_plugin(e)
 
-        return super(ClientManager, self).setup_auth()
+        return super().setup_auth()
 
     def _fallback_load_auth_plugin(self, e):
         # NOTES(RuiChen): Hack to avoid auth plugins choking on data they don't
@@ -170,7 +170,9 @@ def get_plugin_modules(group):
             module = importlib.import_module(module_name)
         except Exception as err:
             sys.stderr.write(
-                "WARNING: Failed to import plugin %s: %s.\n" % (ep.name, err)
+                "WARNING: Failed to import plugin {}: {}.\n".format(
+                    ep.name, err
+                )
             )
             continue
 

openstackclient/common/configuration.py

@@ -27,7 +27,7 @@ class ShowConfiguration(command.ShowOne):
     auth_required = False
 
     def get_parser(self, prog_name):
-        parser = super(ShowConfiguration, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         mask_group = parser.add_mutually_exclusive_group()
         mask_group.add_argument(
             "--mask",

openstackclient/common/extension.py

@@ -148,7 +148,7 @@ class ShowExtension(command.ShowOne):
     _description = _("Show API extension")
 
     def get_parser(self, prog_name):
-        parser = super(ShowExtension, self).get_parser(prog_name)
+        parser = super().get_parser(prog_name)
         parser.add_argument(
             'extension',
             metavar='<extension>',