Skip to content

Commit a6dcb77

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Fix: incremental volume backup"
2 parents 3f781cc + 205bac3 commit a6dcb77

3 files changed

Lines changed: 12 additions & 5 deletions

File tree

openstackclient/tests/unit/volume/v2/test_volume_backup.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ def test_backup_create(self):
120120
name=self.new_backup.name,
121121
description=self.new_backup.description,
122122
force=True,
123-
incremental=True,
123+
is_incremental=True,
124124
snapshot_id=self.new_backup.snapshot_id,
125125
)
126126
self.assertEqual(self.columns, columns)
@@ -150,7 +150,7 @@ def test_backup_create_with_properties(self):
150150
name=None,
151151
description=None,
152152
force=False,
153-
incremental=False,
153+
is_incremental=False,
154154
metadata={"foo": "bar", "wow": "much-cool"},
155155
)
156156
self.assertEqual(self.columns, columns)
@@ -199,7 +199,7 @@ def test_backup_create_with_availability_zone(self):
199199
name=None,
200200
description=None,
201201
force=False,
202-
incremental=False,
202+
is_incremental=False,
203203
availability_zone="my-az",
204204
)
205205
self.assertEqual(self.columns, columns)
@@ -247,7 +247,7 @@ def test_backup_create_without_name(self):
247247
name=None,
248248
description=self.new_backup.description,
249249
force=False,
250-
incremental=False,
250+
is_incremental=False,
251251
)
252252
self.assertEqual(self.columns, columns)
253253
self.assertEqual(self.data, data)

openstackclient/volume/v2/volume_backup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ def take_action(self, parsed_args):
173173
name=parsed_args.name,
174174
description=parsed_args.description,
175175
force=parsed_args.force,
176-
incremental=parsed_args.incremental,
176+
is_incremental=parsed_args.incremental,
177177
**kwargs,
178178
)
179179
data = utils.get_dict_properties(backup, columns)
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
fixes:
3+
- |
4+
Fixed issue with creating incremental volume backup.
5+
Previously, ``incremental`` value was not passed in the
6+
API request which is now included in the backup
7+
create request.

0 commit comments

Comments
 (0)