Merge "Fix --security-group for port list"

Zuul · openstack-gerrit · commit 98fbc56603bd · 2023-10-11T15:59:22.000Z
diff --git a/openstackclient/network/v2/port.py b/openstackclient/network/v2/port.py
@@ -843,7 +843,7 @@ def take_action(self, parsed_args):
                 self.app.client_manager, parsed_args
             )
         if parsed_args.security_groups:
-            filters['security_groups'] = parsed_args.security_groups
+            filters['security_group_ids'] = parsed_args.security_groups
 
         _tag.get_tag_filtering_args(parsed_args, filters)
 
diff --git a/openstackclient/tests/unit/network/v2/test_port.py b/openstackclient/tests/unit/network/v2/test_port.py
@@ -1662,7 +1662,7 @@ def test_port_list_security_group(self):
 
         columns, data = self.cmd.take_action(parsed_args)
         filters = {
-            'security_groups': ['sg-id1', 'sg-id2'],
+            'security_group_ids': ['sg-id1', 'sg-id2'],
             'fields': LIST_FIELDS_TO_RETRIEVE,
         }
 

Original file line number	Diff line number	Diff line change
`@@ -843,7 +843,7 @@ def take_action(self, parsed_args):`
`843`	`843`	`self.app.client_manager, parsed_args`
`844`	`844`	`)`
`845`	`845`	`if parsed_args.security_groups:`
`846`		`- filters['security_groups'] = parsed_args.security_groups`
	`846`	`+ filters['security_group_ids'] = parsed_args.security_groups`
`847`	`847`
`848`	`848`	`_tag.get_tag_filtering_args(parsed_args, filters)`
`849`	`849`
Original file line number	Diff line number	Diff line change
`@@ -1662,7 +1662,7 @@ def test_port_list_security_group(self):`
`1662`	`1662`
`1663`	`1663`	`columns, data = self.cmd.take_action(parsed_args)`
`1664`	`1664`	`filters = {`
`1665`		`- 'security_groups': ['sg-id1', 'sg-id2'],`
	`1665`	`+ 'security_group_ids': ['sg-id1', 'sg-id2'],`
`1666`	`1666`	`'fields': LIST_FIELDS_TO_RETRIEVE,`
`1667`	`1667`	`}`
`1668`	`1668`