Merge "Restore behavior of image create with same name."

Author: Zuul

openstackclient/image/v2/image.py

@@ -354,7 +354,7 @@ def take_action(self, parsed_args):
 
         # Build an attribute dict from the parsed args, only include
         # attributes that were actually set on the command line
-        kwargs = {}
+        kwargs = {'allow_duplicates': True}
         copy_attrs = ('name', 'id',
                       'container_format', 'disk_format',
                       'min_disk', 'min_ram', 'tags', 'visibility')

openstackclient/tests/unit/image/v2/test_image.py

@@ -100,6 +100,7 @@ def test_image_reserve_no_options(self, raw_input):
         # ImageManager.create(name=, **)
         self.client.create_image.assert_called_with(
             name=self.new_image.name,
+            allow_duplicates=True,
             container_format=image.DEFAULT_CONTAINER_FORMAT,
             disk_format=image.DEFAULT_DISK_FORMAT,
         )
@@ -152,6 +153,7 @@ def test_image_reserve_options(self, raw_input):
         # ImageManager.create(name=, **)
         self.client.create_image.assert_called_with(
             name=self.new_image.name,
+            allow_duplicates=True,
             container_format='ovf',
             disk_format='ami',
             min_disk=10,
@@ -239,14 +241,15 @@ def test_image_create_file(self):
         # ImageManager.create(name=, **)
         self.client.create_image.assert_called_with(
             name=self.new_image.name,
+            allow_duplicates=True,
             container_format=image.DEFAULT_CONTAINER_FORMAT,
             disk_format=image.DEFAULT_DISK_FORMAT,
             is_protected=self.new_image.is_protected,
             visibility=self.new_image.visibility,
             Alpha='1',
             Beta='2',
             tags=self.new_image.tags,
-            filename=imagefile.name
+            filename=imagefile.name,
         )
 
         self.assertEqual(
@@ -288,6 +291,7 @@ def test_image_create_import(self, raw_input):
         # ImageManager.create(name=, **)
         self.client.create_image.assert_called_with(
             name=self.new_image.name,
+            allow_duplicates=True,
             container_format=image.DEFAULT_CONTAINER_FORMAT,
             disk_format=image.DEFAULT_DISK_FORMAT,
             use_import=True

releasenotes/notes/restore-create-image-duplicates-92e06f64038b120c.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    Fixes default behaviour of `openstack image create` in allowing images
+    with the same name. In version 5.2.0 this changed to not allow
+    duplicates by default.