Merge "Replace assertEqual(True/False, expr) with assertTrue/assertFalse"

Zuul · openstack-gerrit · commit 955f22314a72 · 2018-12-12T04:38:19.000Z
diff --git a/openstackclient/tests/functional/compute/v2/test_flavor.py b/openstackclient/tests/functional/compute/v2/test_flavor.py
@@ -112,8 +112,7 @@ def test_flavor_list(self):
             0,
             cmd_output["disk"],
         )
-        self.assertEqual(
-            False,
+        self.assertFalse(
             cmd_output["os-flavor-access:is_public"],
         )
         self.assertEqual(
@@ -199,8 +198,7 @@ def test_flavor_properties(self):
             20,
             cmd_output["disk"],
         )
-        self.assertEqual(
-            False,
+        self.assertFalse(
             cmd_output["os-flavor-access:is_public"],
         )
         self.assertEqual(
diff --git a/openstackclient/tests/functional/identity/v2/test_project.py b/openstackclient/tests/functional/identity/v2/test_project.py
@@ -72,7 +72,7 @@ def test_project_set(self):
         self.assert_show_fields(items, fields)
         project = self.parse_show_as_object(raw_output)
         self.assertEqual(new_project_name, project['name'])
-        self.assertEqual('False', project['enabled'])
+        self.assertFalse(project['enabled'])
         self.assertEqual("k0='v0'", project['properties'])
 
     def test_project_show(self):
diff --git a/openstackclient/tests/functional/network/v2/test_address_scope.py b/openstackclient/tests/functional/network/v2/test_address_scope.py
@@ -42,10 +42,7 @@ def test_address_scope_delete(self):
             cmd_output['name'],
         )
         # Check the default values
-        self.assertEqual(
-            False,
-            cmd_output['shared'],
-        )
+        self.assertFalse(cmd_output['shared'])
 
         name2 = uuid.uuid4().hex
         cmd_output = json.loads(self.openstack(
@@ -80,10 +77,7 @@ def test_address_scope_list(self):
             4,
             cmd_output['ip_version'],
         )
-        self.assertEqual(
-            True,
-            cmd_output['shared'],
-        )
+        self.assertTrue(cmd_output['shared'])
 
         name2 = uuid.uuid4().hex
         cmd_output = json.loads(self.openstack(
@@ -101,10 +95,7 @@ def test_address_scope_list(self):
             6,
             cmd_output['ip_version'],
         )
-        self.assertEqual(
-            False,
-            cmd_output['shared'],
-        )
+        self.assertFalse(cmd_output['shared'])
 
         # Test list
         cmd_output = json.loads(self.openstack(
@@ -149,10 +140,7 @@ def test_address_scope_set(self):
             4,
             cmd_output['ip_version'],
         )
-        self.assertEqual(
-            False,
-            cmd_output['shared'],
-        )
+        self.assertFalse(cmd_output['shared'])
 
         raw_output = self.openstack(
             'address scope set ' +
@@ -174,7 +162,4 @@ def test_address_scope_set(self):
             4,
             cmd_output['ip_version'],
         )
-        self.assertEqual(
-            True,
-            cmd_output['shared'],
-        )
+        self.assertTrue(cmd_output['shared'])
diff --git a/openstackclient/tests/functional/network/v2/test_network.py b/openstackclient/tests/functional/network/v2/test_network.py
@@ -70,8 +70,7 @@ def test_network_create_compute(self):
             '1.2.4.0/28',
             cmd_output["cidr"],
         )
-        self.assertEqual(
-            True,
+        self.assertTrue(
             cmd_output["share_address"],
         )
 
@@ -124,8 +123,7 @@ def test_network_create_network(self):
             'UP',
             cmd_output["admin_state_up"],
         )
-        self.assertEqual(
-            False,
+        self.assertFalse(
             cmd_output["shared"],
         )
         self.assertEqual(
@@ -236,21 +234,14 @@ def test_network_list(self):
                 'UP',
                 cmd_output["admin_state_up"],
             )
-            self.assertEqual(
-                False,
-                cmd_output["shared"],
-            )
+            self.assertFalse(cmd_output["shared"])
             self.assertEqual(
                 'Internal',
                 cmd_output["router:external"],
             )
-            self.assertEqual(
-                False,
-                cmd_output["is_default"],
-            )
-            self.assertEqual(
-                True,
-                cmd_output["port_security_enabled"],
+            self.assertFalse(cmd_output["is_default"])
+            self.assertTrue(
+                cmd_output["port_security_enabled"]
             )
         else:
             self.assertEqual(
@@ -278,27 +269,15 @@ def test_network_list(self):
                 'DOWN',
                 cmd_output["admin_state_up"],
             )
-            self.assertEqual(
-                True,
-                cmd_output["shared"],
-            )
-            self.assertEqual(
-                False,
-                cmd_output["is_default"],
-            )
-            self.assertEqual(
-                True,
-                cmd_output["port_security_enabled"],
-            )
+            self.assertTrue(cmd_output["shared"])
+            self.assertFalse(cmd_output["is_default"])
+            self.assertTrue(cmd_output["port_security_enabled"])
         else:
             self.assertEqual(
                 '4.5.6.0/28',
                 cmd_output["cidr"],
             )
-            self.assertEqual(
-                True,
-                cmd_output["share_address"],
-            )
+            self.assertTrue(cmd_output["share_address"])
 
         # Test list
         cmd_output = json.loads(self.openstack(
@@ -422,22 +401,15 @@ def test_network_set(self):
             'UP',
             cmd_output["admin_state_up"],
         )
-        self.assertEqual(
-            False,
-            cmd_output["shared"],
-        )
+        self.assertFalse(cmd_output["shared"])
         self.assertEqual(
             'Internal',
             cmd_output["router:external"],
         )
 
-        self.assertEqual(
-            False,
-            cmd_output["is_default"],
-        )
-        self.assertEqual(
-            True,
-            cmd_output["port_security_enabled"],
+        self.assertFalse(cmd_output["is_default"])
+        self.assertTrue(
+            cmd_output["port_security_enabled"]
         )
 
         raw_output = self.openstack(
@@ -463,19 +435,12 @@ def test_network_set(self):
             'DOWN',
             cmd_output["admin_state_up"],
         )
-        self.assertEqual(
-            True,
-            cmd_output["shared"],
-        )
+        self.assertTrue(cmd_output["shared"])
         self.assertEqual(
             'External',
             cmd_output["router:external"],
         )
-        self.assertEqual(
-            False,
-            cmd_output["is_default"],
-        )
-        self.assertEqual(
-            False,
-            cmd_output["port_security_enabled"],
+        self.assertFalse(cmd_output["is_default"])
+        self.assertFalse(
+            cmd_output["port_security_enabled"]
         )
diff --git a/openstackclient/tests/functional/network/v2/test_network_flavor.py b/openstackclient/tests/functional/network/v2/test_network_flavor.py
@@ -87,10 +87,7 @@ def test_network_flavor_delete(self):
             name1,
             cmd_output['name'],
         )
-        self.assertEqual(
-            True,
-            cmd_output['enabled'],
-        )
+        self.assertTrue(cmd_output['enabled'])
         self.assertEqual(
             'testdescription',
             cmd_output['description'],
@@ -105,10 +102,7 @@ def test_network_flavor_delete(self):
             name2,
             cmd_output['name'],
         )
-        self.assertEqual(
-            False,
-            cmd_output['enabled'],
-        )
+        self.assertFalse(cmd_output['enabled'])
         self.assertEqual(
             'testdescription1',
             cmd_output['description'],
diff --git a/openstackclient/tests/functional/network/v2/test_network_flavor_profile.py b/openstackclient/tests/functional/network/v2/test_network_flavor_profile.py
@@ -35,10 +35,7 @@ def test_network_flavor_profile_create(self):
         ))
         ID = json_output.get('id')
         self.assertIsNotNone(ID)
-        self.assertEqual(
-            True,
-            json_output.get('enabled'),
-        )
+        self.assertTrue(json_output.get('enabled'))
         self.assertEqual(
             'fakedescription',
             json_output.get('description'),
@@ -61,10 +58,7 @@ def test_network_flavor_profile_list(self):
         ))
         ID1 = json_output.get('id')
         self.assertIsNotNone(ID1)
-        self.assertEqual(
-            True,
-            json_output.get('enabled'),
-        )
+        self.assertTrue(json_output.get('enabled'))
         self.assertEqual(
             'fakedescription',
             json_output.get('description'),
@@ -82,10 +76,7 @@ def test_network_flavor_profile_list(self):
         ))
         ID2 = json_output.get('id')
         self.assertIsNotNone(ID2)
-        self.assertEqual(
-            False,
-            json_output.get('enabled'),
-        )
+        self.assertFalse(json_output.get('enabled'))
         self.assertEqual(
             'fakedescription',
             json_output.get('description'),
@@ -120,10 +111,7 @@ def test_network_flavor_profile_set(self):
         ))
         ID = json_output_1.get('id')
         self.assertIsNotNone(ID)
-        self.assertEqual(
-            True,
-            json_output_1.get('enabled'),
-        )
+        self.assertTrue(json_output_1.get('enabled'))
         self.assertEqual(
             'fakedescription',
             json_output_1.get('description'),
@@ -138,10 +126,7 @@ def test_network_flavor_profile_set(self):
         json_output = json.loads(self.openstack(
             'network flavor profile show -f json ' + ID
         ))
-        self.assertEqual(
-            False,
-            json_output.get('enabled'),
-        )
+        self.assertFalse(json_output.get('enabled'))
         self.assertEqual(
             'fakedescription',
             json_output.get('description'),
@@ -171,10 +156,7 @@ def test_network_flavor_profile_show(self):
             ID,
             json_output["id"],
         )
-        self.assertEqual(
-            True,
-            json_output["enabled"],
-        )
+        self.assertTrue(json_output["enabled"])
         self.assertEqual(
             'fakedescription',
             json_output["description"],
diff --git a/openstackclient/tests/functional/network/v2/test_network_meter.py b/openstackclient/tests/functional/network/v2/test_network_meter.py
@@ -48,10 +48,7 @@ def test_meter_delete(self):
             json_output.get('name'),
         )
         # Check if default shared values
-        self.assertEqual(
-            False,
-            json_output.get('shared'),
-        )
+        self.assertFalse(json_output.get('shared'))
         self.assertEqual(
             'fakedescription',
             json_output.get('description'),
@@ -67,10 +64,7 @@ def test_meter_delete(self):
             json_output_2.get('name'),
         )
         # Check if default shared values
-        self.assertEqual(
-            False,
-            json_output_2.get('shared'),
-        )
+        self.assertFalse(json_output_2.get('shared'))
         self.assertEqual(
             'fakedescription',
             json_output_2.get('description'),
@@ -99,10 +93,7 @@ def test_meter_list(self):
             'Test1',
             json_output.get('description'),
         )
-        self.assertEqual(
-            True,
-            json_output.get('shared'),
-        )
+        self.assertTrue(json_output.get('shared'))
 
         name2 = uuid.uuid4().hex
         json_output_2 = json.loads(self.openstack(
@@ -117,8 +108,7 @@ def test_meter_list(self):
             'Test2',
             json_output_2.get('description'),
         )
-        self.assertEqual(
-            False,
+        self.assertFalse(
             json_output_2.get('shared'),
         )
 
@@ -143,10 +133,7 @@ def test_meter_show(self):
         json_output = json.loads(self.openstack(
             'network meter show -f json ' + meter_id
         ))
-        self.assertEqual(
-            False,
-            json_output.get('shared'),
-        )
+        self.assertFalse(json_output.get('shared'))
         self.assertEqual(
             'fakedescription',
             json_output.get('description'),
@@ -164,10 +151,7 @@ def test_meter_show(self):
             meter_id,
             json_output.get('id'),
         )
-        self.assertEqual(
-            False,
-            json_output.get('shared'),
-        )
+        self.assertFalse(json_output.get('shared'))
         self.assertEqual(
             'fakedescription',
             json_output.get('description'),
diff --git a/openstackclient/tests/functional/network/v2/test_router.py b/openstackclient/tests/functional/network/v2/test_router.py
@@ -247,10 +247,7 @@ def test_router_set_show_unset(self):
             'router show -f json ' +
             new_name
         ))
-        self.assertEqual(
-            True,
-            cmd_output["distributed"],
-        )
+        self.assertTrue(cmd_output["distributed"])
         self.assertIsNotNone(cmd_output["external_gateway_info"])
 
         # Test unset

Original file line number	Diff line number	Diff line change
`@@ -112,8 +112,7 @@ def test_flavor_list(self):`
`112`	`112`	`0,`
`113`	`113`	`cmd_output["disk"],`
`114`	`114`	`)`
`115`		`- self.assertEqual(`
`116`		`- False,`
	`115`	`+ self.assertFalse(`
`117`	`116`	`cmd_output["os-flavor-access:is_public"],`
`118`	`117`	`)`
`119`	`118`	`self.assertEqual(`
`@@ -199,8 +198,7 @@ def test_flavor_properties(self):`
`199`	`198`	`20,`
`200`	`199`	`cmd_output["disk"],`
`201`	`200`	`)`
`202`		`- self.assertEqual(`
`203`		`- False,`
	`201`	`+ self.assertFalse(`
`204`	`202`	`cmd_output["os-flavor-access:is_public"],`
`205`	`203`	`)`
`206`	`204`	`self.assertEqual(`