Skip to content

Commit 874933d

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "SDK refactor: Prepare floating ip commands"
2 parents 6bba1f0 + 86a3c7a commit 874933d

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

openstackclient/network/v2/floating_ip.py

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,14 @@
1919

2020
from openstackclient.i18n import _
2121
from openstackclient.network import common
22+
from openstackclient.network import sdk_utils
23+
24+
25+
def _get_network_columns(item):
26+
column_map = {
27+
'tenant_id': 'project_id',
28+
}
29+
return sdk_utils.get_osc_show_columns_for_sdk_resource(item, column_map)
2230

2331

2432
def _get_columns(item):
@@ -110,9 +118,9 @@ def update_parser_network(self, parser):
110118
def take_action_network(self, client, parsed_args):
111119
attrs = _get_attrs(self.app.client_manager, parsed_args)
112120
obj = client.create_ip(**attrs)
113-
columns = _get_columns(obj)
121+
display_columns, columns = _get_network_columns(obj)
114122
data = utils.get_item_properties(obj, columns)
115-
return (columns, data)
123+
return (display_columns, data)
116124

117125
def take_action_compute(self, client, parsed_args):
118126
obj = client.floating_ips.create(parsed_args.network)
@@ -286,9 +294,9 @@ def update_parser_common(self, parser):
286294

287295
def take_action_network(self, client, parsed_args):
288296
obj = client.find_ip(parsed_args.floating_ip, ignore_missing=False)
289-
columns = _get_columns(obj)
297+
display_columns, columns = _get_network_columns(obj)
290298
data = utils.get_item_properties(obj, columns)
291-
return (columns, data)
299+
return (display_columns, data)
292300

293301
def take_action_compute(self, client, parsed_args):
294302
obj = utils.find_resource(

openstackclient/tests/unit/network/v2/test_floating_ip.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ class TestShowFloatingIPNetwork(TestFloatingIPNetwork):
300300
floating_ip.floating_network_id,
301301
floating_ip.id,
302302
floating_ip.port_id,
303-
floating_ip.tenant_id,
303+
floating_ip.project_id,
304304
floating_ip.router_id,
305305
floating_ip.status,
306306
)

0 commit comments

Comments
 (0)