Skip to content

Commit 84c83fc

Browse files
author
Dean Troyer
committed
Provide fallback prompt function for current osc-lib
Leaving the pw_func uninitialize in osc-lib turned out to be a bad idea as the test to prompt in setup_auth() doesn't check for a callback of None. Also, release note Change-Id: I8f875fa8a942d02a040238359ee22c603a4e5956
1 parent c5f8f76 commit 84c83fc

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

openstackclient/common/clientmanager.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import sys
2121

2222
from osc_lib import clientmanager
23+
from osc_lib import shell
2324

2425

2526
LOG = logging.getLogger(__name__)
@@ -48,6 +49,8 @@ def __init__(
4849
super(ClientManager, self).__init__(
4950
cli_options=cli_options,
5051
api_version=api_version,
52+
# TODO(dtroyer): Remove this when osc-lib 1.2 is released
53+
pw_func=shell.prompt_for_password,
5154
)
5255

5356
# TODO(dtroyer): For compatibility; mark this for removal when plugin
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
fixes:
3+
- |
4+
Fix prompting for password issue introduced in release 3.0.0
5+
[Bug `1617384 <https://bugs.launchpad.net/bugs/1617384>`_]

0 commit comments

Comments
 (0)