Retry floating IP tests

test_server_attach_detach_floating_ip() has a test for server
add/remove floating IP that seems to be racy, add a retry loop
to let neutron and nova do their thing before calling it bad.

Change-Id: I999a0d7dae1706d746053bafb7ab4e3b791d0042

Author: Dean Troyer

openstackclient/tests/functional/compute/v2/test_server.py

@@ -11,6 +11,7 @@
 #    under the License.
 
 import json
+import time
 import uuid
 
 from tempest.lib import exceptions
@@ -255,10 +256,24 @@ def test_server_attach_detach_floating_ip(self):
             floating_ip
         )
         self.assertEqual("", raw_output)
-        cmd_output = json.loads(self.openstack(
-            'server show -f json ' +
-            name
-        ))
+
+        # Loop a few times since this is timing-sensitive
+        # Just hard-code it for now, since there is no pause and it is
+        # racy we shouldn't have to wait too long, a minute seems reasonable
+        wait_time = 0
+        while wait_time < 60:
+            cmd_output = json.loads(self.openstack(
+                'server show -f json ' +
+                name
+            ))
+            if floating_ip not in cmd_output['addresses']:
+                # Hang out for a bit and try again
+                print('retrying floating IP check')
+                wait_time += 10
+                time.sleep(10)
+            else:
+                break
+
         self.assertIn(
             floating_ip,
             cmd_output['addresses'],
@@ -272,6 +287,23 @@ def test_server_attach_detach_floating_ip(self):
         )
         self.assertEqual("", raw_output)
 
+        # Loop a few times since this is timing-sensitive
+        # Just hard-code it for now, since there is no pause and it is
+        # racy we shouldn't have to wait too long, a minute seems reasonable
+        wait_time = 0
+        while wait_time < 60:
+            cmd_output = json.loads(self.openstack(
+                'server show -f json ' +
+                name
+            ))
+            if floating_ip in cmd_output['addresses']:
+                # Hang out for a bit and try again
+                print('retrying floating IP check')
+                wait_time += 10
+                time.sleep(10)
+            else:
+                break
+
         cmd_output = json.loads(self.openstack(
             'server show -f json ' +
             name