Skip to content

Commit 82af038

Browse files
committed
properly format error messages for volume resizing
The error messages are tuples and not substituting variables. Before: $ openstack volume set vol1 --size 1 Failed to set volume size: (u'New size must be greater than %s GB', 2) $ openstack volume set vol1 --size 1 Failed to set volume size: (u'Volume is in %s state, it must be available before size can be extended', u'error') After: $ openstack volume set vol2 --size 3 Failed to set volume size: New size must be greater than 4 GB $ openstack volume set vol2 --size 3 Failed to set volume size: Volume is in error state, it must be available before size can be extended Change-Id: Ide6e644b1c6d1c11a9dc2f3f53c1a1837380b8d5
1 parent 43d1646 commit 82af038

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

openstackclient/volume/v2/volume.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -484,10 +484,11 @@ def take_action(self, parsed_args):
484484
try:
485485
if volume.status != 'available':
486486
msg = (_("Volume is in %s state, it must be available "
487-
"before size can be extended"), volume.status)
487+
"before size can be extended") % volume.status)
488488
raise exceptions.CommandError(msg)
489489
if parsed_args.size <= volume.size:
490-
msg = _("New size must be greater than %s GB"), volume.size
490+
msg = (_("New size must be greater than %s GB")
491+
% volume.size)
491492
raise exceptions.CommandError(msg)
492493
volume_client.volumes.extend(volume.id, parsed_args.size)
493494
except Exception as e:

0 commit comments

Comments
 (0)