Skip to content

Commit 813e49d

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "Enable some off-by-default checks"
2 parents e954fe4 + 20c23d8 commit 813e49d

3 files changed

Lines changed: 4 additions & 6 deletions

File tree

openstackclient/tests/functional/volume/v1/test_service.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,7 @@ def test_volume_service_set(self):
6464
'enabled',
6565
cmd_output[0]['Status']
6666
)
67-
self.assertEqual(
68-
None,
69-
cmd_output[0]['Disabled Reason']
70-
)
67+
self.assertIsNone(cmd_output[0]['Disabled Reason'])
7168

7269
# Test volume service set --disable and --disable-reason
7370
disable_reason = 'disable_reason'

openstackclient/tests/functional/volume/v2/test_service.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,7 @@ def test_volume_service_set(self):
6464
'enabled',
6565
cmd_output[0]['Status']
6666
)
67-
self.assertEqual(
68-
None,
67+
self.assertIsNone(
6968
cmd_output[0]['Disabled Reason']
7069
)
7170

tox.ini

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,8 @@ commands = sphinx-build -a -E -W -d releasenotes/build/doctrees -b html releasen
8585

8686
[flake8]
8787
show-source = True
88+
# H203: Use assertIs(Not)None to check for None
89+
enable-extensions = H203
8890
exclude = .git,.tox,dist,doc,*lib/python*,*egg,build,tools
8991
# If 'ignore' is not set there are default errors and warnings that are set
9092
# Doc: http://flake8.readthedocs.org/en/latest/config.html#default

0 commit comments

Comments
 (0)