Skip to content

Commit 7d1a5d0

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "format token expires time to prevent json loading datetime data"
2 parents b4307b1 + 24c8b94 commit 7d1a5d0

6 files changed

Lines changed: 13 additions & 9 deletions

File tree

openstackclient/identity/v2_0/token.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,9 @@ def take_action(self, parsed_args):
4242
if auth_ref.auth_token:
4343
data['id'] = auth_ref.auth_token
4444
if auth_ref.expires:
45-
data['expires'] = auth_ref.expires
45+
datetime_obj = auth_ref.expires
46+
expires_str = datetime_obj.strftime('%Y-%m-%dT%H:%M:%S%z')
47+
data['expires'] = expires_str
4648
if auth_ref.project_id:
4749
data['project_id'] = auth_ref.project_id
4850
if auth_ref.user_id:

openstackclient/identity/v3/token.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,9 @@ def take_action(self, parsed_args):
183183
if auth_ref.auth_token:
184184
data['id'] = auth_ref.auth_token
185185
if auth_ref.expires:
186-
data['expires'] = auth_ref.expires
186+
datetime_obj = auth_ref.expires
187+
expires_str = datetime_obj.strftime('%Y-%m-%dT%H:%M:%S%z')
188+
data['expires'] = expires_str
187189
if auth_ref.project_id:
188190
data['project_id'] = auth_ref.project_id
189191
if auth_ref.user_id:

openstackclient/tests/identity/v2_0/fakes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@
8080
'enabled': True,
8181
}
8282

83-
token_expires = '2014-01-01T00:00:00Z'
83+
token_expires = '2016-09-05T18:04:52+0000'
8484
token_id = 'token-id-' + uuid.uuid4().hex
8585

8686
TOKEN = {

openstackclient/tests/identity/v2_0/test_token.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_token_issue(self):
5858
collist = ('expires', 'id', 'project_id', 'user_id')
5959
self.assertEqual(collist, columns)
6060
datalist = (
61-
auth_ref.expires,
61+
identity_fakes.token_expires,
6262
identity_fakes.token_id,
6363
'project-id',
6464
'user-id',
@@ -86,7 +86,7 @@ def test_token_issue_with_unscoped_token(self):
8686
)
8787
self.assertEqual(collist, columns)
8888
datalist = (
89-
auth_ref.expires,
89+
identity_fakes.token_expires,
9090
identity_fakes.token_id,
9191
'user-id',
9292
)

openstackclient/tests/identity/v3/fakes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@
252252
'trustor_user_id': user_id,
253253
}
254254

255-
token_expires = '2014-01-01T00:00:00Z'
255+
token_expires = '2016-09-05T18:04:52+0000'
256256
token_id = 'tttttttt-tttt-tttt-tttt-tttttttttttt'
257257

258258
UNSCOPED_TOKEN = {

openstackclient/tests/identity/v3/test_token.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def test_token_issue_with_project_id(self):
5555
collist = ('expires', 'id', 'project_id', 'user_id')
5656
self.assertEqual(collist, columns)
5757
datalist = (
58-
auth_ref.expires,
58+
identity_fakes.token_expires,
5959
identity_fakes.token_id,
6060
identity_fakes.project_id,
6161
identity_fakes.user_id,
@@ -82,7 +82,7 @@ def test_token_issue_with_domain_id(self):
8282
self.assertEqual(collist, columns)
8383
datalist = (
8484
identity_fakes.domain_id,
85-
auth_ref.expires,
85+
identity_fakes.token_expires,
8686
identity_fakes.token_id,
8787
identity_fakes.user_id,
8888
)
@@ -109,7 +109,7 @@ def test_token_issue_with_unscoped(self):
109109
)
110110
self.assertEqual(collist, columns)
111111
datalist = (
112-
auth_ref.expires,
112+
identity_fakes.token_expires,
113113
identity_fakes.token_id,
114114
identity_fakes.user_id,
115115
)

0 commit comments

Comments
 (0)