Skip to content

Commit 776b7d0

Browse files
gtemastephenfin
authored andcommitted
Adopt sdk_fakes for compute.test_usage
Depends-On: https://review.opendev.org/c/openstack/openstacksdk/+/882682 Change-Id: Ia8fd2ccfd1e86749fdeeb49c2d57de64635cbb82
1 parent afc0d3c commit 776b7d0

2 files changed

Lines changed: 12 additions & 64 deletions

File tree

openstackclient/tests/unit/compute/v2/fakes.py

Lines changed: 0 additions & 57 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
from openstack.compute.v2 import server_group as _server_group
3333
from openstack.compute.v2 import server_interface as _server_interface
3434
from openstack.compute.v2 import server_migration as _server_migration
35-
from openstack.compute.v2 import usage as _usage
3635
from openstack.compute.v2 import volume_attachment as _volume_attachment
3736

3837
from openstackclient.tests.unit import fakes
@@ -810,62 +809,6 @@ def get_networks(networks=None, count=2):
810809
return mock.Mock(side_effect=networks)
811810

812811

813-
def create_one_usage(attrs=None):
814-
"""Create a fake usage.
815-
816-
:param dict attrs:
817-
A dictionary with all attributes
818-
:return:
819-
A FakeResource object, with tenant_id and other attributes
820-
"""
821-
if attrs is None:
822-
attrs = {}
823-
824-
# Set default attributes.
825-
usage_info = {
826-
'project_id': 'usage-tenant-id-' + uuid.uuid4().hex,
827-
'total_memory_mb_usage': 512.0,
828-
'total_vcpus_usage': 1.0,
829-
'total_local_gb_usage': 1.0,
830-
'server_usages': [
831-
{
832-
'ended_at': None,
833-
'flavor': 'usage-flavor-' + uuid.uuid4().hex,
834-
'hours': 1.0,
835-
'local_gb': 1,
836-
'memory_mb': 512,
837-
'name': 'usage-name-' + uuid.uuid4().hex,
838-
'instance_id': uuid.uuid4().hex,
839-
'state': 'active',
840-
'uptime': 3600,
841-
'vcpus': 1,
842-
}
843-
],
844-
}
845-
846-
# Overwrite default attributes.
847-
usage_info.update(attrs)
848-
849-
return _usage.Usage(**usage_info)
850-
851-
852-
def create_usages(attrs=None, count=2):
853-
"""Create multiple fake services.
854-
855-
:param dict attrs:
856-
A dictionary with all attributes
857-
:param int count:
858-
The number of services to fake
859-
:return:
860-
A list of FakeResource objects faking the services
861-
"""
862-
usages = []
863-
for i in range(0, count):
864-
usages.append(create_one_usage(attrs))
865-
866-
return usages
867-
868-
869812
def create_limits(attrs=None):
870813
"""Create a fake limits object."""
871814
attrs = attrs or {}

openstackclient/tests/unit/compute/v2/test_usage.py

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,12 @@
1414
import datetime
1515
from unittest import mock
1616

17+
from openstack.compute.v2 import usage as _usage
18+
from openstack.identity.v3 import project as _project
19+
from openstack.test import fakes as sdk_fakes
20+
1721
from openstackclient.compute.v2 import usage as usage_cmds
1822
from openstackclient.tests.unit.compute.v2 import fakes as compute_fakes
19-
from openstackclient.tests.unit.identity.v3 import fakes as identity_fakes
2023

2124

2225
class TestUsage(compute_fakes.TestComputev2):
@@ -28,11 +31,11 @@ def setUp(self):
2831

2932

3033
class TestUsageList(TestUsage):
31-
project = identity_fakes.FakeProject.create_one_project()
34+
project = sdk_fakes.generate_fake_resource(_project.Project)
3235
# Return value of self.usage_mock.list().
33-
usages = compute_fakes.create_usages(
34-
attrs={'project_id': project.name}, count=1
35-
)
36+
usages = [
37+
sdk_fakes.generate_fake_resource(_usage.Usage, project_id=project.name)
38+
]
3639

3740
columns = (
3841
"Project",
@@ -123,9 +126,11 @@ def test_usage_list_with_pagination(self):
123126

124127

125128
class TestUsageShow(TestUsage):
126-
project = identity_fakes.FakeProject.create_one_project()
129+
project = sdk_fakes.generate_fake_resource(_project.Project)
127130
# Return value of self.usage_mock.list().
128-
usage = compute_fakes.create_one_usage(attrs={'project_id': project.name})
131+
usage = sdk_fakes.generate_fake_resource(
132+
_usage.Usage, project_id=project.name
133+
)
129134

130135
columns = (
131136
'Project',

0 commit comments

Comments
 (0)