Add "fields" parameter to ListSecurityGroup query

This new query parameter will allow to send a query sending the
"fields" parameter. This "fields" parameter contains the needed
API fields, translated into OVO fields in Neutron server, that
require to be retrieved from the DB.

As commented in the related bug, the OSC "list" command only
prints five parameters, none of them the security group rules. In
systems with a reasonable amount of security groups, skipping the
unnecessary rule load can save a lot of time.

Depends-On: https://review.opendev.org/#/c/710820/
Change-Id: I16f48e292997d029d68f66365db949b9f4b5a0c8
Closes-Bug: #1865223

Author: ralonsoh

openstackclient/network/v2/security_group.py

@@ -202,6 +202,7 @@ def take_action_compute(self, client, parsed_args):
 # the OSC minimum requirements include SDK 1.0.
 class ListSecurityGroup(common.NetworkAndComputeLister):
     _description = _("List security groups")
+    FIELDS_TO_RETRIEVE = ['id', 'name', 'description', 'project_id', 'tags']
 
     def update_parser_network(self, parser):
         if not self.is_docs_build:
@@ -251,7 +252,8 @@ def take_action_network(self, client, parsed_args):
             filters['project_id'] = project_id
 
         _tag.get_tag_filtering_args(parsed_args, filters)
-        data = client.security_groups(**filters)
+        data = client.security_groups(fields=self.FIELDS_TO_RETRIEVE,
+                                      **filters)
 
         columns = (
             "ID",

openstackclient/tests/unit/network/v2/test_security_group_network.py

@@ -285,7 +285,8 @@ def test_security_group_list_no_options(self):
 
         columns, data = self.cmd.take_action(parsed_args)
 
-        self.network.security_groups.assert_called_once_with()
+        self.network.security_groups.assert_called_once_with(
+            fields=security_group.ListSecurityGroup.FIELDS_TO_RETRIEVE)
         self.assertEqual(self.columns, columns)
         self.assertListItemEqual(self.data, list(data))
 
@@ -300,7 +301,8 @@ def test_security_group_list_all_projects(self):
 
         columns, data = self.cmd.take_action(parsed_args)
 
-        self.network.security_groups.assert_called_once_with()
+        self.network.security_groups.assert_called_once_with(
+            fields=security_group.ListSecurityGroup.FIELDS_TO_RETRIEVE)
         self.assertEqual(self.columns, columns)
         self.assertListItemEqual(self.data, list(data))
 
@@ -316,7 +318,9 @@ def test_security_group_list_project(self):
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         columns, data = self.cmd.take_action(parsed_args)
-        filters = {'tenant_id': project.id, 'project_id': project.id}
+        filters = {
+            'tenant_id': project.id, 'project_id': project.id,
+            'fields': security_group.ListSecurityGroup.FIELDS_TO_RETRIEVE}
 
         self.network.security_groups.assert_called_once_with(**filters)
         self.assertEqual(self.columns, columns)
@@ -336,7 +340,9 @@ def test_security_group_list_project_domain(self):
         parsed_args = self.check_parser(self.cmd, arglist, verifylist)
 
         columns, data = self.cmd.take_action(parsed_args)
-        filters = {'tenant_id': project.id, 'project_id': project.id}
+        filters = {
+            'tenant_id': project.id, 'project_id': project.id,
+            'fields': security_group.ListSecurityGroup.FIELDS_TO_RETRIEVE}
 
         self.network.security_groups.assert_called_once_with(**filters)
         self.assertEqual(self.columns, columns)
@@ -362,7 +368,8 @@ def test_list_with_tag_options(self):
             **{'tags': 'red,blue',
                'any_tags': 'red,green',
                'not_tags': 'orange,yellow',
-               'not_any_tags': 'black,white'}
+               'not_any_tags': 'black,white',
+               'fields': security_group.ListSecurityGroup.FIELDS_TO_RETRIEVE}
         )
         self.assertEqual(self.columns, columns)
         self.assertEqual(self.data, list(data))