Skip to content

Commit 518420a

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "compute: Remove unnecessary try-except"
2 parents ca81b1a + 40ce562 commit 518420a

1 file changed

Lines changed: 12 additions & 23 deletions

File tree

openstackclient/compute/v2/server.py

Lines changed: 12 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -4844,17 +4844,12 @@ def get_parser(self, prog_name):
48444844
def take_action(self, parsed_args):
48454845
compute_client = self.app.client_manager.sdk_connection.compute
48464846
for server in parsed_args.server:
4847-
try:
4848-
server_id = compute_client.find_server(
4849-
server,
4850-
ignore_missing=False,
4851-
details=False,
4852-
all_projects=parsed_args.all_projects,
4853-
).id
4854-
except sdk_exceptions.HttpException as exc:
4855-
if exc.status_code == 403:
4856-
msg = _("Policy doesn't allow passing all-projects")
4857-
raise exceptions.Forbidden(msg)
4847+
server_id = compute_client.find_server(
4848+
server,
4849+
ignore_missing=False,
4850+
details=False,
4851+
all_projects=parsed_args.all_projects,
4852+
).id
48584853

48594854
compute_client.start_server(server_id)
48604855

@@ -4884,18 +4879,12 @@ def get_parser(self, prog_name):
48844879
def take_action(self, parsed_args):
48854880
compute_client = self.app.client_manager.sdk_connection.compute
48864881
for server in parsed_args.server:
4887-
try:
4888-
server_id = compute_client.find_server(
4889-
server,
4890-
ignore_missing=False,
4891-
details=False,
4892-
all_projects=parsed_args.all_projects,
4893-
).id
4894-
except sdk_exceptions.HttpException as exc:
4895-
if exc.status_code == 403:
4896-
msg = _("Policy doesn't allow passing all-projects")
4897-
raise exceptions.Forbidden(msg)
4898-
4882+
server_id = compute_client.find_server(
4883+
server,
4884+
ignore_missing=False,
4885+
details=False,
4886+
all_projects=parsed_args.all_projects,
4887+
).id
48994888
compute_client.stop_server(server_id)
49004889

49014890

0 commit comments

Comments
 (0)