Skip to content

Commit 4b97a85

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "Refactor network fakes to sdk properties PART 4"
2 parents 9b399c5 + ccd84f8 commit 4b97a85

17 files changed

Lines changed: 414 additions & 434 deletions

openstackclient/network/v2/network_agent.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ def _get_network_columns(item):
5050
'is_admin_state_up': 'admin_state_up',
5151
'is_alive': 'alive',
5252
}
53-
hidden_columns = ['location']
53+
hidden_columns = ['location', 'name']
5454
return utils.get_osc_show_columns_for_sdk_resource(
5555
item,
5656
column_map,

openstackclient/network/v2/network_flavor_profile.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def _get_columns(item):
2929
'is_enabled': 'enabled',
3030
}
3131

32-
hidden_columns = ['location']
32+
hidden_columns = ['location', 'name', 'tenant_id']
3333
return utils.get_osc_show_columns_for_sdk_resource(
3434
item,
3535
column_map,
@@ -166,7 +166,7 @@ def take_action(self, parsed_args):
166166
'id',
167167
'driver',
168168
'is_enabled',
169-
'metainfo',
169+
'meta_info',
170170
'description',
171171
)
172172
column_headers = (

openstackclient/network/v2/network_rbac.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def _get_columns(item):
3030
column_map = {
3131
'target_tenant': 'target_project_id',
3232
}
33-
hidden_columns = ['location']
33+
hidden_columns = ['location', 'name', 'tenant_id']
3434
return utils.get_osc_show_columns_for_sdk_resource(
3535
item,
3636
column_map,

openstackclient/network/v2/port.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def _get_columns(item):
6464
'is_admin_state_up': 'admin_state_up',
6565
'is_port_security_enabled': 'port_security_enabled',
6666
}
67-
hidden_columns = ['location']
67+
hidden_columns = ['location', 'tenant_id']
6868
return utils.get_osc_show_columns_for_sdk_resource(
6969
item,
7070
column_map,

openstackclient/tests/unit/compute/v2/test_server.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -592,7 +592,7 @@ def setUp(self):
592592
def test_server_add_floating_ip(self):
593593
_server = compute_fakes.FakeServer.create_one_server()
594594
self.servers_mock.get.return_value = _server
595-
_port = network_fakes.FakePort.create_one_port()
595+
_port = network_fakes.create_one_port()
596596
_floating_ip = network_fakes.FakeFloatingIP.create_one_floating_ip()
597597
self.network.find_ip = mock.Mock(return_value=_floating_ip)
598598
self.network.ports = mock.Mock(return_value=[_port])
@@ -661,7 +661,7 @@ def test_server_add_floating_ip_no_ports(self):
661661
def test_server_add_floating_ip_no_external_gateway(self, success=False):
662662
_server = compute_fakes.FakeServer.create_one_server()
663663
self.servers_mock.get.return_value = _server
664-
_port = network_fakes.FakePort.create_one_port()
664+
_port = network_fakes.create_one_port()
665665
_floating_ip = network_fakes.FakeFloatingIP.create_one_floating_ip()
666666
self.network.find_ip = mock.Mock(return_value=_floating_ip)
667667
return_value = [_port]
@@ -717,7 +717,7 @@ def test_server_add_floating_ip_one_external_gateway(self):
717717
def test_server_add_floating_ip_with_fixed_ip(self):
718718
_server = compute_fakes.FakeServer.create_one_server()
719719
self.servers_mock.get.return_value = _server
720-
_port = network_fakes.FakePort.create_one_port()
720+
_port = network_fakes.create_one_port()
721721
_floating_ip = network_fakes.FakeFloatingIP.create_one_floating_ip()
722722
self.network.find_ip = mock.Mock(return_value=_floating_ip)
723723
self.network.ports = mock.Mock(return_value=[_port])
@@ -759,7 +759,7 @@ def test_server_add_floating_ip_with_fixed_ip(self):
759759
def test_server_add_floating_ip_with_fixed_ip_no_port_found(self):
760760
_server = compute_fakes.FakeServer.create_one_server()
761761
self.servers_mock.get.return_value = _server
762-
_port = network_fakes.FakePort.create_one_port()
762+
_port = network_fakes.create_one_port()
763763
_floating_ip = network_fakes.FakeFloatingIP.create_one_floating_ip()
764764
self.network.find_ip = mock.Mock(return_value=_floating_ip)
765765
self.network.ports = mock.Mock(return_value=[_port])

0 commit comments

Comments
 (0)