Merge "Accept 0 for --min-disk and --min-ram"

Author: Zuul

openstackclient/image/v1/image.py

@@ -625,11 +625,11 @@ def take_action(self, parsed_args):
         kwargs = {}
         copy_attrs = ('name', 'owner', 'min_disk', 'min_ram', 'properties',
                       'container_format', 'disk_format', 'size', 'store',
-                      'location', 'copy_from', 'volume', 'force', 'checksum')
+                      'location', 'copy_from', 'volume', 'checksum')
         for attr in copy_attrs:
             if attr in parsed_args:
                 val = getattr(parsed_args, attr, None)
-                if val:
+                if val is not None:
                     # Only include a value in kwargs for attributes that are
                     # actually present on the command line
                     kwargs[attr] = val
@@ -653,6 +653,8 @@ def take_action(self, parsed_args):
             kwargs['is_public'] = True
         if parsed_args.private:
             kwargs['is_public'] = False
+        if parsed_args.force:
+            kwargs['force'] = True
 
         # Wrap the call to catch exceptions in order to close files
         try:

openstackclient/image/v2/image.py

@@ -749,7 +749,7 @@ def get_parser(self, prog_name):
             "--tag",
             dest="tags",
             metavar="<tag>",
-            default=[],
+            default=None,
             action='append',
             help=_("Set a tag on this image "
                    "(repeat option to set multiple tags)"),
@@ -860,7 +860,7 @@ def take_action(self, parsed_args):
         for attr in copy_attrs:
             if attr in parsed_args:
                 val = getattr(parsed_args, attr, None)
-                if val:
+                if val is not None:
                     # Only include a value in kwargs for attributes that are
                     # actually present on the command line
                     kwargs[attr] = val

openstackclient/tests/unit/image/v1/test_image.py

@@ -689,6 +689,32 @@ def test_image_update_volume(self):
         )
         self.assertIsNone(result)
 
+    def test_image_set_numeric_options_to_zero(self):
+        arglist = [
+            '--min-disk', '0',
+            '--min-ram', '0',
+            self._image.name,
+        ]
+        verifylist = [
+            ('min_disk', 0),
+            ('min_ram', 0),
+            ('image', self._image.name),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        result = self.cmd.take_action(parsed_args)
+
+        kwargs = {
+            'min_disk': 0,
+            'min_ram': 0,
+        }
+        # ImageManager.update(image, **kwargs)
+        self.images_mock.update.assert_called_with(
+            self._image.id,
+            **kwargs
+        )
+        self.assertIsNone(result)
+
 
 class TestImageShow(TestImage):
 

openstackclient/tests/unit/image/v2/test_image.py

@@ -1313,6 +1313,32 @@ def test_image_set_dead_options(self):
             exceptions.CommandError,
             self.cmd.take_action, parsed_args)
 
+    def test_image_set_numeric_options_to_zero(self):
+        arglist = [
+            '--min-disk', '0',
+            '--min-ram', '0',
+            image_fakes.image_name,
+        ]
+        verifylist = [
+            ('min_disk', 0),
+            ('min_ram', 0),
+            ('image', image_fakes.image_name),
+        ]
+        parsed_args = self.check_parser(self.cmd, arglist, verifylist)
+
+        result = self.cmd.take_action(parsed_args)
+
+        kwargs = {
+            'min_disk': 0,
+            'min_ram': 0,
+        }
+        # ImageManager.update(image, **kwargs)
+        self.images_mock.update.assert_called_with(
+            image_fakes.image_id,
+            **kwargs
+        )
+        self.assertIsNone(result)
+
 
 class TestImageShow(TestImage):
 

releasenotes/notes/bug-1719499-d67d80b0da0bc30a.yaml

@@ -0,0 +1,5 @@
+---
+fixes:
+  - |
+    Accept ``0`` as a valid value in the ``image set`` ``--min-disk`` and ``--min-ram`` options.
+    .. _bug 1719499: https://bugs.launchpad.net/python-openstackclient/+bug/1719499