Warning for empty password set for user create/set

Raise warning when empty password set for user

Change-Id: If03516f3f1290e4c329fe3d1277dee0512de0410
Closes-Bug: #1607959

Author: qiangtang

openstackclient/identity/v2_0/user.py

@@ -94,6 +94,10 @@ def take_action(self, parsed_args):
         if parsed_args.password_prompt:
             parsed_args.password = utils.get_password(self.app.stdin)
 
+        if not parsed_args.password:
+            LOG.warning(_("No password was supplied, authentication will fail "
+                          "when a user does not have a password."))
+
         try:
             user = identity_client.users.create(
                 parsed_args.name,
@@ -292,6 +296,10 @@ def take_action(self, parsed_args):
         if parsed_args.password_prompt:
             parsed_args.password = utils.get_password(self.app.stdin)
 
+        if '' == parsed_args.password:
+            LOG.warning(_("No password was supplied, authentication will fail "
+                          "when a user does not have a password."))
+
         user = utils.find_resource(
             identity_client.users,
             parsed_args.user,

openstackclient/identity/v3/user.py

@@ -110,6 +110,10 @@ def take_action(self, parsed_args):
         if parsed_args.password_prompt:
             parsed_args.password = utils.get_password(self.app.stdin)
 
+        if not parsed_args.password:
+            LOG.warning(_("No password was supplied, authentication will fail "
+                          "when a user does not have a password."))
+
         try:
             user = identity_client.users.create(
                 name=parsed_args.name,
@@ -329,6 +333,10 @@ def take_action(self, parsed_args):
         if parsed_args.password_prompt:
             parsed_args.password = utils.get_password(self.app.stdin)
 
+        if '' == parsed_args.password:
+            LOG.warning(_("No password was supplied, authentication will fail "
+                          "when a user does not have a password."))
+
         user = utils.find_resource(
             identity_client.users,
             parsed_args.user,
@@ -408,6 +416,10 @@ def take_action(self, parsed_args):
             password = utils.get_password(
                 self.app.stdin, prompt="New Password:")
 
+        if '' == password:
+            LOG.warning(_("No password was supplied, authentication will fail "
+                          "when a user does not have a password."))
+
         identity_client.users.update_password(current_password, password)
 
 

releasenotes/notes/bug-1607959-a52aa93e3793f28a.yaml

@@ -0,0 +1,6 @@
+---
+fixes:
+  - |
+    A warning message will be shown when an empty password is used
+    for ``user create`` and ``user set`` operations.
+    [Bug `1607959 <https://bugs.launchpad.net/bugs/1607959>`_]