Skip to content

Commit 368a250

Browse files
committed
SDK Refactor: Prepare network segment commands
Prepare the OSC "network segment" commands for the SDK refactor. See [1] for details. [1] https://etherpad.openstack.org/p/osc-network-command-sdk-support Change-Id: I426ecdad0f9d95b89e80fb1c5ba81ffe5fe274c9 Partially-Implements: blueprint network-command-sdk-support
1 parent 70cb628 commit 368a250

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

openstackclient/network/v2/network_segment.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,16 @@
2020
from osc_lib import utils
2121

2222
from openstackclient.i18n import _
23+
from openstackclient.network import sdk_utils
2324

2425

2526
LOG = logging.getLogger(__name__)
2627

2728

29+
def _get_columns(item):
30+
return sdk_utils.get_osc_show_columns_for_sdk_resource(item, {})
31+
32+
2833
class CreateNetworkSegment(command.ShowOne):
2934
"""Create new network segment"""
3035

@@ -84,9 +89,9 @@ def take_action(self, parsed_args):
8489
if parsed_args.segment is not None:
8590
attrs['segmentation_id'] = parsed_args.segment
8691
obj = client.create_segment(**attrs)
87-
columns = tuple(sorted(obj.keys()))
92+
display_columns, columns = _get_columns(obj)
8893
data = utils.get_item_properties(obj, columns)
89-
return (columns, data)
94+
return (display_columns, data)
9095

9196

9297
class DeleteNetworkSegment(command.Command):
@@ -236,6 +241,6 @@ def take_action(self, parsed_args):
236241
parsed_args.network_segment,
237242
ignore_missing=False
238243
)
239-
columns = tuple(sorted(obj.keys()))
244+
display_columns, columns = _get_columns(obj)
240245
data = utils.get_item_properties(obj, columns)
241-
return (columns, data)
246+
return (display_columns, data)

0 commit comments

Comments
 (0)