Skip to content

Commit 35dc858

Browse files
author
Huanxuan Ao
committed
Revert "Fix port command for SDK >0.9.10"
This reverts commit 8e277c6. After [1] merged in osc-lib, we can Avoid 'NoneType' error when format conversion now, So [2] in no longer needed, we can clean it up. Hold this until [1] released and included in the requirement in OSC. [1] https://review.openstack.org/#/c/434768/ [2] https://review.openstack.org/#/c/420420/ Depend-On: I649b4fc65ef7c19b8193b07f3bd59f00e6095f9f Change-Id: I2783713102d5e6164d9617f130c2f595bd6d939e
1 parent a934400 commit 35dc858

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

openstackclient/network/v2/port.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ def _format_admin_state(state):
3535
return 'UP' if state else 'DOWN'
3636

3737

38-
def _format_dns_assignment(dns_assignment):
39-
return utils.format_list_of_dicts(dns_assignment) \
40-
if dns_assignment else None
41-
4238
_formatters = {
4339
'admin_state_up': _format_admin_state,
4440
'is_admin_state_up': _format_admin_state,
@@ -47,7 +43,7 @@ def _format_dns_assignment(dns_assignment):
4743
'binding_vif_details': utils.format_dict,
4844
'binding:profile': utils.format_dict,
4945
'binding:vif_details': utils.format_dict,
50-
'dns_assignment': _format_dns_assignment,
46+
'dns_assignment': utils.format_list_of_dicts,
5147
'extra_dhcp_opts': utils.format_list_of_dicts,
5248
'fixed_ips': utils.format_list_of_dicts,
5349
'security_group_ids': utils.format_list,

0 commit comments

Comments
 (0)